labath resigned from this revision.
labath removed a reviewer: labath.
labath added a comment.
I am cleaning out my review queue. Feel free to add me back when you want to
get this moving again...
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
labath closed this revision.
labath added a comment.
This was committed ages ago.
http://reviews.llvm.org/D15241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath closed this revision.
labath added a comment.
This was committed ages ago.
http://reviews.llvm.org/D15834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bhushan added a comment.
Hi @zturner,
Can you please "accept" this revision so that I can "close" this one?
Repository:
rL LLVM
http://reviews.llvm.org/D17022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: ewancrawford
Date: Tue Mar 15 04:50:16 2016
New Revision: 263544
URL: http://llvm.org/viewvc/llvm-project?rev=263544&view=rev
Log:
Fix expression evaluation for resolving anonymous aggregrate types with a
typedefed name
This fixes a recently reported a
bug(https://llvm.org/bugs/show_bug
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
This also adds a basic smoke test for linux core file reading. I'm checking in
the core files as
well, so that the tests can run on all platforms. With some tricks I was able
to produce
reaso
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263547: Add regression test for expressions calling
functions taking anonymous struct… (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D1?vs=49524&id=50719#toc
Reposito
Author: ewancrawford
Date: Tue Mar 15 08:02:11 2016
New Revision: 263547
URL: http://llvm.org/viewvc/llvm-project?rev=263547&view=rev
Log:
Add regression test for expressions calling functions taking anonymous struct
typedef arguments
This CL adds a regression test for the bug listed at
https:/
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
These are not needed in lldb-server. Removing them shrinks the server size by
about 1.5%.
http://reviews.llvm.org/D18188
Files:
source/API/SystemInitializerFull.cpp
source/Initialization
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Good to see we have a way to generate reasonably sized core files on other
platforms as well.
http://reviews.llvm.org/D18176
___
lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM, Pavel!
http://reviews.llvm.org/D18140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
ClangASTContext was assuming the presence of DWARF debug info, so it was baked
into the class that DWARFASTParserClang would be used. This won't be the case
with PDB, which will need a P
zturner abandoned this revision.
zturner added a comment.
Abandoning this for now, I ran into some difficulties when trying to implement
the PDB version. Will have to resolve those first and then come back to this.
http://reviews.llvm.org/D18194
_
Author: jingham
Date: Tue Mar 15 16:11:02 2016
New Revision: 263588
URL: http://llvm.org/viewvc/llvm-project?rev=263588&view=rev
Log:
Remove unnecessary includes.
Modified:
lldb/trunk/source/Core/DataEncoder.cpp
lldb/trunk/source/Core/DataExtractor.cpp
lldb/trunk/source/Core/Disassem
Is the stdint version better somehow? I thought C++ numeric_limits were
actually preferred over the C macros.
On Mon, Mar 14, 2016 at 7:59 AM Adrian McCarthy via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> If we're favoring the macros over the functions, then
> perhaps update the #inc
It doesn't look like there is any advantage to the numeric_limits if you
already know the type you are getting the max or min of. The template would be
nice for doing more generic programming, but we're never doing anything fancier
than "What is the max of a uint32_t". It doesn't look like the
Author: enrico
Date: Tue Mar 15 16:50:51 2016
New Revision: 263592
URL: http://llvm.org/viewvc/llvm-project?rev=263592&view=rev
Log:
Improve the 'type lookup' command such that it guesses to use the current's
frame language as the one to start searching from.
Modified:
lldb/trunk/include/lld
I agree that they are pretty much equivalent, I guess the main advantage I
see is that you don't have to think about what type something is when
assigning it an "invalid" value. For example, LLDB_INVALID_THREAD_ID could
just as easily be std::numeric_limits::min(), and then you
don't have to worry
Author: gclayton
Date: Tue Mar 15 16:58:28 2016
New Revision: 263593
URL: http://llvm.org/viewvc/llvm-project?rev=263593&view=rev
Log:
Don't crash if the TypeSP is empty.
Modified:
lldb/trunk/include/lldb/Symbol/Type.h
Modified: lldb/trunk/include/lldb/Symbol/Type.h
URL:
http://llvm.org/vi
> On Mar 15, 2016, at 3:00 PM, Zachary Turner wrote:
>
> I agree that they are pretty much equivalent, I guess the main advantage I
> see is that you don't have to think about what type something is when
> assigning it an "invalid" value. For example, LLDB_INVALID_THREAD_ID could
> just as e
This actually broke a couple of unit tests on Windows. Did you try running
these tests on Windows?
On Fri, Mar 11, 2016 at 12:49 AM Pavel Labath wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL263207: Fix a couple of cornercases in FileSpe
Author: gclayton
Date: Tue Mar 15 17:43:26 2016
New Revision: 263601
URL: http://llvm.org/viewvc/llvm-project?rev=263601&view=rev
Log:
Fix ClangASTContext::GetFunctionArgumentAtIndex() to not water down the type to
the canonical type before handing the type out for the function type.
Modified:
Author: gclayton
Date: Tue Mar 15 17:44:07 2016
New Revision: 263602
URL: http://llvm.org/viewvc/llvm-project?rev=263602&view=rev
Log:
Only try to load the OS plug-in after a shared library load if we don't already
have one.
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/t
Author: enrico
Date: Tue Mar 15 18:20:10 2016
New Revision: 263603
URL: http://llvm.org/viewvc/llvm-project?rev=263603&view=rev
Log:
Make it so that the data formatter for NSError can see through a variable of
type NSError**. Fixes rdar://25060684
Modified:
lldb/trunk/packages/Python/lldbsu
Author: enrico
Date: Tue Mar 15 18:38:04 2016
New Revision: 263604
URL: http://llvm.org/viewvc/llvm-project?rev=263604&view=rev
Log:
On some platforms, the compiler is allowed to assume that BOOL == bool. On
others, BOOL == signed char.
This can cause differences in which bit patterns end up mean
Great! Attached is the update.
On Thu, Mar 10, 2016 at 6:57 PM, Jim Ingham wrote:
> Few more comments...
>
> +/// If an address comes from an existing module, then it will be resolved
> +/// into an offset from its containing section in that module. That way
> it
> +/// can refer to the same l
The only other suggestion I have is that the first time we refer to a module in
this file
we should say "(see SBModule)" or something like that to make it clear what we
mean by a module.
Other than that this looks good to me.
Jim
> On Mar 15, 2016, at 5:05 PM, John Lindal wrote:
>
> Great!
bhushan closed this revision.
bhushan added a comment.
Closed by commit http://reviews.llvm.org/rL261206
Repository:
rL LLVM
http://reviews.llvm.org/D17022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
28 matches
Mail list logo
