Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-14 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. Looks great. Thank you. Repository: rL LLVM http://reviews.llvm.org/D18082 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

Re: [Lldb-commits] [PATCH] D18096: accept any build-id length between 4 and 20 bytes inclusive

2016-03-14 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. I think that's fine (you may want to add a note about the crc to the comment). http://reviews.llvm.org/D18096 ___

[Lldb-commits] [PATCH] D18140: [test] Persist packets between expect_gdbremote_sequence invocations

2016-03-14 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tfiala. labath added a subscriber: lldb-commits. Some tests (Hc_then_Csignal_signals_correct_thread, at least) were sending a "continue" packet in one expect_gdbremote_sequence invocation, and "expecting" the stop-reply in another call. This

[Lldb-commits] [lldb] r263421 - Extend XFlaky in TestProcessIO to linux as well

2016-03-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 14 06:19:39 2016 New Revision: 263421 URL: http://llvm.org/viewvc/llvm-project?rev=263421&view=rev Log: Extend XFlaky in TestProcessIO to linux as well The test sometimes fails on local linux as well. The cause is the same. Modified: lldb/trunk/packages/Python/l

Re: [Lldb-commits] [PATCH] D18096: accept any build-id length between 4 and 20 bytes inclusive

2016-03-14 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263432: Allow any build-id length between 4 and 20 bytes inclusive (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D18096?vs=50464&id=50587#toc Repository: rL LLVM http://revi

[Lldb-commits] [lldb] r263432 - Allow any build-id length between 4 and 20 bytes inclusive

2016-03-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Mar 14 09:06:00 2016 New Revision: 263432 URL: http://llvm.org/viewvc/llvm-project?rev=263432&view=rev Log: Allow any build-id length between 4 and 20 bytes inclusive Build-id support is being added to lld and by default it may produce a 64-bit build-id. Prior to this ch

[Lldb-commits] [PATCH] D18146: [test] Correctly retry connections on android targets

2016-03-14 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: tfiala, tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Normally, when the remote stub is not ready, we will get ECONNREFUSED during the connect() attempt. However, due to the wa

Re: [Lldb-commits] [PATCH] D17972: [TestRegisterVariables] Adjust compiler range in expected failure decorator.

2016-03-14 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. Now failing on FreeBSD: http://llvm.org/pr26937 Repository: rL LLVM http://reviews.llvm.org/D17972 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [Lldb-commits] [lldb] r263333 - Let's not convert from UINT32_MAX to the std::numeric_limits version.

2016-03-14 Thread Adrian McCarthy via lldb-commits
If we're favoring the macros over the functions, then perhaps update the #includes? On Fri, Mar 11, 2016 at 7:33 PM, Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Fri Mar 11 21:33:36 2016 > New Revision: 26 > > URL: http://llvm.org/viewvc/llvm-p

Re: [Lldb-commits] [lldb] r262970 - [TestRegisterVariables] Adjust compiler range in expected failure decorator.

2016-03-14 Thread Ed Maste via lldb-commits
On 8 March 2016 at 19:02, Siva Chandra via lldb-commits wrote: > Author: sivachandra > Date: Tue Mar 8 18:02:00 2016 > New Revision: 262970 > > -@expectedFailureAll(compiler="clang", compiler_version=['<', '3.5']) > +@expectedFailureAll(compiler="clang", compiler_version=['>', '3.5']) Th

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 50595. EwanCrawford added a comment. Thanks for taking a look Sean. I moved the mangling logic into `LanguageCPlusPlus` and created a new method for it. There was an existing function `FindEquivalentNames` that used `CPPRuntimeEquivalents`, but looked

Re: [Lldb-commits] [PATCH] D18146: [test] Correctly retry connections on android targets

2016-03-14 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D18146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [Lldb-commits] [PATCH] D18146: [test] Correctly retry connections on android targets

2016-03-14 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263439: [test] Correctly retry connections on android targets (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18146?vs=50600&id=50601#toc Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [PATCH] D18146: [test] Correctly retry connections on android targets

2016-03-14 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 50600. labath added a comment. Fix comment http://reviews.llvm.org/D18146 Files: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Index: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py =

[Lldb-commits] [lldb] r263439 - [test] Correctly retry connections on android targets

2016-03-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 14 10:33:25 2016 New Revision: 263439 URL: http://llvm.org/viewvc/llvm-project?rev=263439&view=rev Log: [test] Correctly retry connections on android targets Summary: Normally, when the remote stub is not ready, we will get ECONNREFUSED during the connect() attempt.

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-03-14 Thread Francis Ricci via lldb-commits
fjricci abandoned this revision. fjricci added a comment. This functionality can already be accessed by using the "process connect" command with a listen url directly. http://reviews.llvm.org/D17099 ___ lldb-commits mailing list lldb-commits@lists.

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) Maybe we can have a standard clean rule in the main makefiles: stand

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) clayborg wrote: > Maybe we can have a standard clean rule in the ma

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Ewan Crawford via lldb-commits
EwanCrawford added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) labath wrote: > clayborg wrote: > > Maybe we can have a standard c

Re: [Lldb-commits] [lldb] r262970 - [TestRegisterVariables] Adjust compiler range in expected failure decorator.

2016-03-14 Thread Siva Chandra via lldb-commits
On Mon, Mar 14, 2016 at 8:08 AM, Ed Maste wrote: > On 8 March 2016 at 19:02, Siva Chandra via lldb-commits > wrote: >> Author: sivachandra >> Date: Tue Mar 8 18:02:00 2016 >> New Revision: 262970 >> >> -@expectedFailureAll(compiler="clang", compiler_version=['<', '3.5']) >> +@expectedFai

[Lldb-commits] [lldb] r263467 - Enable expectedFailure for all Clang versions in TestRegisterVariables

2016-03-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Mar 14 13:59:44 2016 New Revision: 263467 URL: http://llvm.org/viewvc/llvm-project?rev=263467&view=rev Log: Enable expectedFailure for all Clang versions in TestRegisterVariables In r262970 this was changed from xfail Clang < 3.5 to > 3.5, but it still fails on FreeBSD 10

[Lldb-commits] [lldb] r263468 - More of the alias refactoring work! CommandAlias is now a CommandObject

2016-03-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Mar 14 14:00:21 2016 New Revision: 263468 URL: http://llvm.org/viewvc/llvm-project?rev=263468&view=rev Log: More of the alias refactoring work! CommandAlias is now a CommandObject Modified: lldb/trunk/include/lldb/Interpreter/CommandAlias.h lldb/trunk/include/lld

Re: [Lldb-commits] [PATCH] D17402: Shuffle an #undef to avoid a warning on FreeBSD

2016-03-14 Thread Chaoren Lin via lldb-commits
chaoren accepted this revision. chaoren added a comment. This revision is now accepted and ready to land. Seems legit. http://reviews.llvm.org/D17402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r263486 - Shuffle an #undef to avoid a warning on FreeBSD

2016-03-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Mar 14 15:39:08 2016 New Revision: 263486 URL: http://llvm.org/viewvc/llvm-project?rev=263486&view=rev Log: Shuffle an #undef to avoid a warning on FreeBSD On FreeBSD _LIBCPP_EXTERN_TEMPLATE is being defined from something included by lldb/lldb-private.h. Undefine it afte

Re: [Lldb-commits] [PATCH] D17402: Shuffle an #undef to avoid a warning on FreeBSD

2016-03-14 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263486: Shuffle an #undef to avoid a warning on FreeBSD (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D17402?vs=48364&id=50641#toc Repository: rL LLVM http://reviews.llvm.or

[Lldb-commits] [lldb] r263499 - Lots of progress on the CommandAlias refactoring

2016-03-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Mar 14 17:17:04 2016 New Revision: 263499 URL: http://llvm.org/viewvc/llvm-project?rev=263499&view=rev Log: Lots of progress on the CommandAlias refactoring This cleans things up such CommandAlias essentially can work as its own object; the aliases still live in a separa

[Lldb-commits] [lldb] r263517 - This was printing arguments twice in dash-dash aliases; don't do that

2016-03-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Mar 14 20:17:32 2016 New Revision: 263517 URL: http://llvm.org/viewvc/llvm-project?rev=263517&view=rev Log: This was printing arguments twice in dash-dash aliases; don't do that Modified: lldb/trunk/source/Interpreter/Options.cpp Modified: lldb/trunk/source/Interpret

[Lldb-commits] [lldb] r263520 - Add some test coverage for the changes in alias help

2016-03-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Mar 14 20:43:00 2016 New Revision: 263520 URL: http://llvm.org/viewvc/llvm-project?rev=263520&view=rev Log: Add some test coverage for the changes in alias help Modified: lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r263519 - Improve the way we decide whether an alias is a dashdash alias

2016-03-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Mar 14 20:42:34 2016 New Revision: 263519 URL: http://llvm.org/viewvc/llvm-project?rev=263519&view=rev Log: Improve the way we decide whether an alias is a dashdash alias Modified: lldb/trunk/source/Interpreter/CommandAlias.cpp Modified: lldb/trunk/source/Interprete

[Lldb-commits] [lldb] r263523 - Workaround the fact that "b" is now a separate command object from "_regexp-break", and thus "help b" doesn't show the possible syntaxes

2016-03-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Mar 14 20:57:10 2016 New Revision: 263523 URL: http://llvm.org/viewvc/llvm-project?rev=263523&view=rev Log: Workaround the fact that "b" is now a separate command object from "_regexp-break", and thus "help b" doesn't show the possible syntaxes It would be nice to have a

[Lldb-commits] [lldb] r263529 - Bump the lldb version # in the xcode project files from

2016-03-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Mar 14 23:36:11 2016 New Revision: 263529 URL: http://llvm.org/viewvc/llvm-project?rev=263529&view=rev Log: Bump the lldb version # in the xcode project files from 350.99.0 to 360.99.0. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/resources/LLD

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-14 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Hi Tamas Berghammer, Is it ok to commit? Repository: rL LLVM http://reviews.llvm.org/D18082 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits