[Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

2016-02-25 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added a reviewer: clayborg. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The MIPS/MICROMIPS architecture will generate different jump instruction.

[Lldb-commits] [lldb] r261858 - Handle the case when a variable is only valid in part of the enclosing scope

2016-02-25 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Feb 25 06:23:37 2016 New Revision: 261858 URL: http://llvm.org/viewvc/llvm-project?rev=261858&view=rev Log: Handle the case when a variable is only valid in part of the enclosing scope DWARF stores this information in the DW_AT_start_scope attribute. This CL add supp

Re: [Lldb-commits] [PATCH] D17449: Handle the case when a variable is only valid in part of the enclosing scope

2016-02-25 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261858: Handle the case when a variable is only valid in part of the enclosing scope (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D17449?vs=48908&id=49034#toc Repository:

[Lldb-commits] [lldb] r261859 - Add support for handling absolute symbols in ELF

2016-02-25 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Thu Feb 25 06:23:43 2016 New Revision: 261859 URL: http://llvm.org/viewvc/llvm-project?rev=261859&view=rev Log: Add support for handling absolute symbols in ELF Most address represented in lldb as section plus offset and handling of absolute addresses is problematic in s

Re: [Lldb-commits] [PATCH] D17450: Add support for handling absolute symbols in ELF

2016-02-25 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261859: Add support for handling absolute symbols in ELF (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D17450?vs=48947&id=49036#toc Repository: rL LLVM http://reviews.l

[Lldb-commits] [lldb] r261861 - Improve readability and performance of ClangExpressionParser::FindFunctionInModule

2016-02-25 Thread Aidan Dodds via lldb-commits
Author: aidandodds Date: Thu Feb 25 07:07:04 2016 New Revision: 261861 URL: http://llvm.org/viewvc/llvm-project?rev=261861&view=rev Log: Improve readability and performance of ClangExpressionParser::FindFunctionInModule Committed on behalf of: Luke Drummond Differential Revision: http://reviews

Re: [Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

2016-02-25 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261861: Improve readability and performance of ClangExpressionParser… (authored by aidandodds). Changed prior to commit: http://reviews.llvm.org/D17274?vs=48003&id=49045#toc Repository: rL LLVM http

Re: [Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

2016-02-25 Thread Luke Drummond via lldb-commits
ldrumm added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560 @@ -558,5 +558,4 @@ -static bool FindFunctionInModule (ConstString &mangled_name, - llvm::Module *module, -

[Lldb-commits] [PATCH] D17604: Add support for DW_OP_push_object_address in dwarf expressions

2016-02-25 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: ovyalov, clayborg. tberghammer added a subscriber: lldb-commits. Add support for DW_OP_push_object_address in dwarf expressions Additionally fix the type of some dwarf expression where we had a confusion between scalar and load addr

Re: [Lldb-commits] [PATCH] D17545: Fix PythonDataObjectsTests for python 2

2016-02-25 Thread Pavel Labath via lldb-commits
labath added a comment. Any thoughts on this? This is currently the only failing unit test on linux. http://reviews.llvm.org/D17545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-25 Thread Cameron via lldb-commits
cameron314 removed rL LLVM as the repository for this revision. cameron314 updated this revision to Diff 49066. cameron314 added a comment. Here's a new version of the patch which takes into account most of the feedback so far (less `#ifdefs`, etc.). It depends on my pending patch in LLVM (http:

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-25 Thread Cameron via lldb-commits
cameron314 added inline comments. Comment at: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp:618 @@ -616,3 +617,3 @@ -static char pBuffer[MAX_PATH]; +static char pBuffer[PATH_MAX]; const MIuint nBytes = rFrame.GetLineEntry().GetFileSpec().GetPath(&pBuffer[0

Re: [Lldb-commits] [PATCH] D17545: Fix PythonDataObjectsTests for python 2

2016-02-25 Thread Zachary Turner via lldb-commits
Sorry, was out for a few days and i missed this. Seems ok then On Thu, Feb 25, 2016 at 8:25 AM Pavel Labath wrote: > labath added a comment. > > Any thoughts on this? > > This is currently the only failing unit test on linux. > > > http://reviews.llvm.org/D17545 > > > > _

[Lldb-commits] [lldb] r261901 - Fix PythonDataObjectsTests for python 2

2016-02-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 25 11:41:59 2016 New Revision: 261901 URL: http://llvm.org/viewvc/llvm-project?rev=261901&view=rev Log: Fix PythonDataObjectsTests for python 2 Summary: the python2 branch seems erroneous as it expected the object to be both a "String" and "Bytes". Fix the expectatio

Re: [Lldb-commits] [PATCH] D17545: Fix PythonDataObjectsTests for python 2

2016-02-25 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261901: Fix PythonDataObjectsTests for python 2 (authored by labath). Changed prior to commit: http://reviews.llvm.org/D17545?vs=48820&id=49081#toc Repository: rL LLVM http://reviews.llvm.org/D17545

Re: [Lldb-commits] [PATCH] D17604: Add support for DW_OP_push_object_address in dwarf expressions

2016-02-25 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D17604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

2016-02-25 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: ovyalov, clayborg. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. Add a set of new plugins to handle Java debugging The purpose of these plugins is to make LLDB capable of debugging ja

Re: [Lldb-commits] [PATCH] D17604: Add support for DW_OP_push_object_address in dwarf expressions

2016-02-25 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. LGTM http://reviews.llvm.org/D17604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

2016-02-25 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D17616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-25 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: spyffe, clayborg. sivachandra added a subscriber: lldb-commits. This, in a way, extends the existing "workaroud" by matching function argument type names individually [instead of just matching "(args1...)" with "(args2...)"]. For type

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-25 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 49098. sivachandra added a comment. Fix a comment in file, fix formatting in another. http://reviews.llvm.org/D17618 Files: include/lldb/Symbol/SymbolFile.h packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py packages/Python/lldbsuite/test/lang

[Lldb-commits] [lldb] r261920 - Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectTarget.cpp; other minor fixes.

2016-02-25 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Thu Feb 25 13:02:39 2016 New Revision: 261920 URL: http://llvm.org/viewvc/llvm-project?rev=261920&view=rev Log: Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectTarget.cpp; other minor fixes. Modified: lldb/tr

[Lldb-commits] [lldb] r261936 - Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectThread.cpp; other minor fixes.

2016-02-25 Thread Eugene Zelenko via lldb-commits
Author: eugenezelenko Date: Thu Feb 25 17:46:36 2016 New Revision: 261936 URL: http://llvm.org/viewvc/llvm-project?rev=261936&view=rev Log: Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in source/Commands/CommandObjectThread.cpp; other minor fixes. Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

2016-02-25 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35 @@ +34,3 @@ +lldb::TypeSP +DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc, const DWARFDIE &die, + lldb_private

Re: [Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

2016-02-25 Thread Enrico Granata via lldb-commits
granata.enrico added a subscriber: granata.enrico. Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81 @@ +80,3 @@ +HardcodedFormatters::HardcodedSummaryFinder +JavaLanguage::GetHardcodedSummaries() +{ Is there any reason to use hardcoded summaries here?

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-25 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. I'm growing more comfortable with these changes, but I'll defer to Zach. Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:242 @@ -221,1 +241,3 @@ +path.push_back(0); +path.pop_back(); } I recognize that you're

[Lldb-commits] [lldb] r261950 - Fix all of the unannotated switch cases to annotate the fall through or do the right thing and break.

2016-02-25 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Feb 25 19:20:20 2016 New Revision: 261950 URL: http://llvm.org/viewvc/llvm-project?rev=261950&view=rev Log: Fix all of the unannotated switch cases to annotate the fall through or do the right thing and break. Modified: lldb/trunk/source/Core/ArchSpec.cpp lldb

[Lldb-commits] [lldb] r261953 - Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function

2016-02-25 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Feb 25 19:37:30 2016 New Revision: 261953 URL: http://llvm.org/viewvc/llvm-project?rev=261953&view=rev Log: Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function to allow you to step through a complex calling sequence

Re: [Lldb-commits] [PATCH] D17618: Improve looking up functions with equivalent mangled names.

2016-02-25 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 49138. sivachandra added a comment. Add more gtest unittests. http://reviews.llvm.org/D17618 Files: include/lldb/Symbol/SymbolFile.h packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py packages/Python/lldbsuite/test/lang/cpp/stl/main.cpp sour

Re: [Lldb-commits] [lldb] r261953 - Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function

2016-02-25 Thread Chaoren Lin via lldb-commits
Hi Jim, This broke a lot of our tests on Linux. E.g., "p foo" doesn't work. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11803 Since the breakage is pretty severe, mind if I revert this first until the problem can be fixed? On Thu, Feb 25, 2016 at 5:42 PM Jim Ingham vi

Re: [Lldb-commits] [lldb] r261953 - Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function

2016-02-25 Thread Jason Molenda via lldb-commits
Jim just headed home - if you don't mind, please revert the commit. He'll look into it tomorrow morning. J > On Feb 25, 2016, at 6:51 PM, Chaoren Lin via lldb-commits > wrote: > > Hi Jim, > > This broke a lot of our tests on Linux. E.g., "p foo" doesn't work. > http://lab.llvm.org:8011/bui

[Lldb-commits] [PATCH] D17634: Clear alias argument vector for 'p' alias.

2016-02-25 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: jingham. chaoren added a subscriber: lldb-commits. This fixes the 'p' command which should be aliased to 'expresion --'. http://reviews.llvm.org/D17634 Files: source/Interpreter/CommandInterpreter.cpp Index: source/Interpreter/CommandIn

Re: [Lldb-commits] [PATCH] D17634: Clear alias argument vector for 'p' alias.

2016-02-25 Thread Chaoren Lin via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261969: Clear alias argument vector for 'p' alias. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17634?vs=49147&id=49148#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r261969 - Clear alias argument vector for 'p' alias.

2016-02-25 Thread Chaoren Lin via lldb-commits
Author: chaoren Date: Thu Feb 25 21:36:27 2016 New Revision: 261969 URL: http://llvm.org/viewvc/llvm-project?rev=261969&view=rev Log: Clear alias argument vector for 'p' alias. Summary: This fixes the 'p' command which should be aliased to 'expresion --'. Reviewers: jingham Subscribers: lldb-co

[Lldb-commits] [PATCH] D17635: Continue after process exit

2016-02-25 Thread Petr Hons via lldb-commits
Honsik created this revision. Honsik added a reviewer: zturner. Honsik added a subscriber: lldb-commits. When process exits, and SBProcess.Continue() is executed, timeout occurs (5secs). Instead error message "Process is not alive" is returned. Added test for this message. Fix of breakpoint cas

[Lldb-commits] [lldb] r261974 - Make TestPlatformProcessConnect to support abstract/domain sockets.

2016-02-25 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Thu Feb 25 22:01:58 2016 New Revision: 261974 URL: http://llvm.org/viewvc/llvm-project?rev=261974&view=rev Log: Make TestPlatformProcessConnect to support abstract/domain sockets. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/platform-process-co

Re: [Lldb-commits] [lldb] r261953 - Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function

2016-02-25 Thread Chaoren Lin via lldb-commits
It's okay. I think I fixed it with http://reviews.llvm.org/D17634 On Thu, Feb 25, 2016 at 6:55 PM, Jason Molenda wrote: > Jim just headed home - if you don't mind, please revert the commit. He'll > look into it tomorrow morning. > > J > > > > On Feb 25, 2016, at 6:51 PM, Chaoren Lin via lldb-co