labath accepted this revision.
labath added a comment.
So, linux actually manages to invoke the atexit handlers (through some deep
magic, no doubt) upon shared library unload, so we are ok here (plus linux
likes to nuke /tmp after every reboot). LGTM, with a small RAII request.
===
Author: labath
Date: Fri Feb 19 04:36:31 2016
New Revision: 261313
URL: http://llvm.org/viewvc/llvm-project?rev=261313&view=rev
Log:
Mark TestLldbGdbServer.test_software_breakpoint_set_and_remove_work_llgs as
flaky on linux
The problem is the asynchronous arrival of inferior stdio (pr25652).
Mo
Author: labath
Date: Fri Feb 19 04:36:38 2016
New Revision: 261314
URL: http://llvm.org/viewvc/llvm-project?rev=261314&view=rev
Log:
Enable TestUnicodeLiterals
Test should work everywhere except windows now.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/TestU
Author: tberghammer
Date: Fri Feb 19 04:59:25 2016
New Revision: 261318
URL: http://llvm.org/viewvc/llvm-project?rev=261318&view=rev
Log:
Stack unwinding emulation: handle adjustment of FP
This change is improving the instruction emulation based unwinding to
handle when the frame pointer is adjus
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261318: Stack unwinding emulation: handle adjustment of FP
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D17295?vs=48078&id=48472#toc
Repository:
rL LLVM
http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261328: Delete unused function in ClangExpressionParser
(authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D17266?vs=47980&id=48484#toc
Repository:
rL LLVM
http://reviews.l
Author: ewancrawford
Date: Fri Feb 19 08:31:41 2016
New Revision: 261328
URL: http://llvm.org/viewvc/llvm-project?rev=261328&view=rev
Log:
Delete unused function in ClangExpressionParser
[git 65dafa83] introduced the GetBuiltinIncludePath function copied from
cfe/lib/Driver/CC1Options.cpp
This
mamai updated this revision to Diff 48486.
mamai added a comment.
I have updated the patch to add the assertion.
Repository:
rL LLVM
http://reviews.llvm.org/D17167
Files:
source/Expression/Materializer.cpp
Index: source/Expression/Materializer.cpp
=
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clay.chang.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Handle the case when a variable is only valid in part of the enclosing scope
DWARF stores this information in the DW
tberghammer created this revision.
tberghammer added reviewers: ovyalov, clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for handling absolute symbols in ELF
Most address represented in lldb as section plus offset and handling of
absolute addresses is problematic in several lo
Author: emaste
Date: Fri Feb 19 10:58:08 2016
New Revision: 261333
URL: http://llvm.org/viewvc/llvm-project?rev=261333&view=rev
Log:
Remove XFAIL from test passing on FreeBSD
Both Linux and FreeBSD had a comment "This needs to be root-caused."
It looks like the failure has been fixed on both, and
Author: emaste
Date: Fri Feb 19 11:31:05 2016
New Revision: 261339
URL: http://llvm.org/viewvc/llvm-project?rev=261339&view=rev
Log:
Remove XFAIL from test passing on FreeBSD
This is passing for me consistently on FreeBSD 10 and FreeBSD 11.
llvm.org/pr15989
Modified:
lldb/trunk/packages/Py
Author: emaste
Date: Fri Feb 19 11:35:01 2016
New Revision: 261340
URL: http://llvm.org/viewvc/llvm-project?rev=261340&view=rev
Log:
Remove XFAIL from test passing on FreeBSD
There is a report in the PR from several months ago that it failed
intermittently, but it is passing consistently for me o
emaste created this revision.
emaste added a reviewer: zturner.
emaste added a subscriber: lldb-commits.
All invocations are updated to use the generic expectedFailureAll.
http://reviews.llvm.org/D17455
Files:
packages/Python/lldbsuite/test/decorators.py
packages/Python/lldbsuite/test/expr
Author: ewancrawford
Date: Fri Feb 19 11:55:10 2016
New Revision: 261345
URL: http://llvm.org/viewvc/llvm-project?rev=261345&view=rev
Log:
refactor/cleanup ClangExpressionParser::Parse
This patches does the following:
+ fix return type: ClangExpressionParser::Parse returns unsigned, but was
act
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261345: refactor/cleanup ClangExpressionParser::Parse
(authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D17273?vs=48002&id=48507#toc
Repository:
rL LLVM
http://reviews.llv
zturner added inline comments.
Comment at:
packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py:26-27
@@ -25,4 +25,4 @@
@skipIfFreeBSD # llvm.org/pr24691 skipping to avoid crashing the test
runner
-@expectedFailureFreeBSD('llvm.org/pr19011') #
clayborg added a comment.
General things to know about SymbolFiles:
- We use SymbolContext objects to refer to a specific symbol context: module,
compile unit, function, deepest block, line entry and symbol.
- A load address should produce 1 symbol context. Never more.
- A file address can produ
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
DWARF already has support for this using location lists. I would rather see
this done by having the DWARF parser modify the DWARF expression to be a
location list based. I don't
On Fri, Feb 19, 2016 at 10:43 AM Greg Clayton wrote:
>
> We should be covering this using API tests that make an example like the
> one above and setting breakpoints in the inline header file. We have many
> tests for this. It is hard to get compilers to generate things that you can
> put in unit
Author: zturner
Date: Fri Feb 19 13:20:44 2016
New Revision: 261353
URL: http://llvm.org/viewvc/llvm-project?rev=261353&view=rev
Log:
Don't use an atexit handler for cleaning up the temp directory.
Differential Revision: http://reviews.llvm.org/D17420
Modified:
lldb/trunk/include/lldb/Host/H
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261353: Don't use an atexit handler for cleaning up the temp
directory. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D17420?vs=48414&id=48528#toc
Repository:
rL LLVM
http:
emaste updated this revision to Diff 48529.
emaste added a comment.
Address zturner feedback
http://reviews.llvm.org/D17455
Files:
packages/Python/lldbsuite/test/decorators.py
packages/Python/lldbsuite/test/expression_command/call-function/TestCallStdStringFunction.py
packages/Python/lld
emaste added inline comments.
Comment at:
packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py:26-27
@@ -25,5 +25,4 @@
@skipIfFreeBSD # llvm.org/pr24691 skipping to avoid crashing the test
runner
-@expectedFailureFreeBSD('llvm.org/pr19011') # N
Author: emaste
Date: Fri Feb 19 13:25:03 2016
New Revision: 261355
URL: http://llvm.org/viewvc/llvm-project?rev=261355&view=rev
Log:
Remove expectedFailureFreeBSD decorator
All invocations are updated to use the generic expectedFailureAll.
Differential Revision: http://reviews.llvm.org/D17455
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261355: Remove expectedFailureFreeBSD decorator (authored by
emaste).
Changed prior to commit:
http://reviews.llvm.org/D17455?vs=48529&id=48533#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17455
Author: eugenezelenko
Date: Fri Feb 19 13:33:46 2016
New Revision: 261356
URL: http://llvm.org/viewvc/llvm-project?rev=261356&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in some
files in source/Commands; other minor fixes.
Modified:
lldb/trunk/source
Please don't make this sort of change. With the code as originally written, I
can set a breakpoint on the returns "true" or "false" case separately, and stop
there if I am doing that experiment, whereas your change makes that impossible.
Neither one is particularly harder to read than the othe
On Fri, Feb 19, 2016 at 12:33 PM, Jim Ingham wrote:
> Please don't make this sort of change. With the code as originally written,
> I can set a breakpoint on the returns "true" or "false" case separately, and
> stop there if I am doing that experiment, whereas your change makes that
> impossib
zturner marked 6 inline comments as done.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:82-83
@@ +81,4 @@
+auto error = llvm::loadDataForEXE(llvm::PDB_ReaderType::DIA,
llvm::StringRef(exePath), m_session);
+if (error != llvm::PDB_ErrorCode::Success)
zturner updated this revision to Diff 48544.
zturner added a comment.
This should address all (I think) issues except for the one about
`check_inlines`, which I'll do in a followup. Can you respond to my comment in
a previous update about the uniqueness / index-ness of the comp_unit id?
http:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should probably make it such that if a section has the type
eSectionTypeAbsoluteAddress that we do the right thing inside the following
functions:
Section::GetLoadBaseAddress
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:150
@@ +149,3 @@
+return TranslateLanguage(details->getLanguage());
+}
+
Ahh i see the problem. The problem is not the value Im' specifying for the id
of the compile u
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So your LineTable::Entry objects that you create are still invalid since you
didn't implement the support files.
All comments became unaligned but you did comment that:
> In Com
tfiala added a reviewer: spyffe.
tfiala added a comment.
+Sean
Sean, I'm okay with this for now. You know my changes coming down the pipe,
and I can add a configuration setting for the git side that lets us optionally
add in the history truncation. Thoughts?
http://reviews.llvm.org/D17425
tfiala added a comment.
(Stephane, I've got a change in the works that is currently backed up behind
some other things, but it allows better mapping of Xcode lldb configuration to
llvm/clang configuration, and includes specifying if svn or git should be used.
It will actually default to svn.
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
32-bit processes on 64-bit Windows run in a layer called WoW64
(Windows-on-Windows64). If you capture a mini dump of such a process from a
32-bit debugger, you end up with a register c
zturner added a comment.
I'll have to look at this more carefully next week. I'm guessing the same
logic can eventually be re-used to live debug a 32-bit process from a 64-bit
LLDB? (Not that you have to address that now, just curious)
http://reviews.llvm.org/D17465
__
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:192
@@ +191,3 @@
+// only about the position of the TlsSlots.
+struct TEB64 {
+ULONG64 Reserved1[12];
I think this structure should go in a different head
Author: eugenezelenko
Date: Fri Feb 19 18:58:29 2016
New Revision: 261389
URL: http://llvm.org/viewvc/llvm-project?rev=261389&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in some
files in source/Commands; other minor fixes.
Modified:
lldb/trunk/source
Hello everyone,
LLVM buildmaster will be updated and restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
41 matches
Mail list logo
