[Lldb-commits] [lldb] r258621 - [LLDB] Consider only valid symbols while resolving by address

2016-01-23 Thread Mohit K. Bhakkad via lldb-commits
Author: mohit.bhakkad Date: Sat Jan 23 04:36:06 2016 New Revision: 258621 URL: http://llvm.org/viewvc/llvm-project?rev=258621&view=rev Log: [LLDB] Consider only valid symbols while resolving by address Reviewers: clayborg. Subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. Different

Re: [Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

2016-01-23 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258621: [LLDB] Consider only valid symbols while resolving by address (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D16397?vs=45670&id=45789#toc Repository: rL LLVM h

[Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: emaste, joerg, clayborg, tfiala. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Add basic support, i386 version will be added later. Repository: rL LLVM http://reviews.ll

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I had difficulties with this code, as each platform implements it differently. What is DBG? What should be there? What is UserArea? What should be there? Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-c

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D16508#334424, @krytarowski wrote: > I had difficulties with this code, as each platform implements it differently. This class is one of the parts of the infrastructure needed to access registers for a given platform. These show up on the LLD

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Todd Fiala via lldb-commits
tfiala added a comment. The important part is that you look to see what NetBSD exposes register-wise for a given process. Even though the architecture is the same across several different versions of this class, it is possible for an OS to tweak the way the CPU starts up and therefore influenc

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Todd Fiala via lldb-commits
tfiala added a comment. If all else fails when trying to look up the NetBSD expectations about register access, you can start with the ptrace interface (man ptrace). It should have some way for you to ask for some kind of register-file-offset-based value and a width to retrieve content from th

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. @tfiala thank you for your verbose and quick feedback. It made the things more clear! While I'm processing your reply -- a question, does it matter whether we define GPR as signed or unsigned integers? Is it platform specific part too? Should I change this to `uint

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. For the reference, I hold on with pushing this forward, till I will get significantly larger coverage with tests on my platform. I keep this patch locally for local development. Repository: rL LLVM http://reviews.llvm.org/D15067 __

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. NetBSD currently doesn't support debug registers. Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

Re: [Lldb-commits] [lldb] r258546 - Silence -Wreturn-type warnings

2016-01-23 Thread Joerg Sonnenberger via lldb-commits
On Fri, Jan 22, 2016 at 08:26:30PM -, Saleem Abdulrasool via lldb-commits wrote: > Author: compnerd > Date: Fri Jan 22 14:26:30 2016 > New Revision: 258546 > > URL: http://llvm.org/viewvc/llvm-project?rev=258546&view=rev > Log: > Silence -Wreturn-type warnings > > Address a couple of instanc

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D16508#334452, @krytarowski wrote: > @tfiala thank you for your verbose and quick feedback. It made the things > more clear! My pleasure! > While I'm processing your reply -- a question, does it matter whether we > define GPR as signed or un

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Joerg Sonnenberger via lldb-commits
On Sat, Jan 23, 2016 at 04:02:19PM +, Kamil Rytarowski via lldb-commits wrote: > Add basic support, i386 version will be added later. I think you want to keep at least the mc_tlsbase field as well. Access to __thread variables will need it. Joerg _

Re: [Lldb-commits] [lldb] r258621 - [LLDB] Consider only valid symbols while resolving by address

2016-01-23 Thread Zachary Turner via lldb-commits
What is this fixing and how can we write a test for it? On Sat, Jan 23, 2016 at 2:40 AM Mohit K. Bhakkad via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: mohit.bhakkad > Date: Sat Jan 23 04:36:06 2016 > New Revision: 258621 > > URL: http://llvm.org/viewvc/llvm-project?rev=258621&v