Author: ewancrawford
Date: Mon Nov 30 04:29:49 2015
New Revision: 254294
URL: http://llvm.org/viewvc/llvm-project?rev=254294&view=rev
Log:
[RS] Support RenderScript struct allocations
This patch adds functionality for dumping allocations of struct elements. This
involves:
+ Jitting the runt
labath added subscribers: artagnon, Eugene.Zelenko, tfiala.
labath added a comment.
It seems to follow what clang does here, so I think it should be ok.
However, I'm not actually using the standalone build... I've added some people
who I think might be using it. Let's give them a bit of time to
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Note: We will have to enable the same functionality for some variant of mips
also but I don't know the details so we should leave it for the mips guys.
http://reviews.llvm.org
abhishek.aggarwal updated this revision to Diff 41382.
abhishek.aggarwal added a comment.
Removed assert if ptrace API fails
http://reviews.llvm.org/D15042
Files:
packages/Python/lldbsuite/test/functionalities/return-value/TestReturnValue.py
source/Plugins/Process/Linux/NativeRegisterContex
clayborg added a comment.
Yep, I took care of that shortly after your commit.
Repository:
rL LLVM
http://reviews.llvm.org/D14793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a subscriber: zturner.
zturner requested changes to this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision now requires changes to proceed.
@labath, can you point out where clang is doing the same thing? I searched for
files named `regcomp.c` for e
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If this is indeed a very similar test, we should fix the original test to do
the right thing.
Repository:
rL LLVM
http://reviews.llvm.org/D14944
__
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
One minor nit, but looks good.
Comment at: source/Target/Process.cpp:4622
@@ +4621,3 @@
+
+if (interrupt_requested) {
+if (StateIsStoppedState
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Jason Molenda should be sufficient to review this.
http://reviews.llvm.org/D15046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
labath added a comment.
Hmm.. you are right, of course.. I was only looking at the second version of
the patch, which seems to omit the regex files. However that seems to by
accidental, as they are still references in the CMake files.
I agree that we should not copy the files over.
@krytarowsk
zturner added a comment.
lldb-mi is including from the source tree, it should be including from the
incldue tree.
In other words, the incldue should be changed to:
#include "llvm/Support/Regex.h"
and the code should be updated to use `llvm::Regex` instead of the raw c
functions.
Repositor
labath requested changes to this revision.
labath added a comment.
OK, llvm seems to export the regex interface via include/llvm/Support/Regex.h.
I think we should fix lldb-mi to use this interface instead, and then our
problem will go away. The MI wrapper seems to be very simple, so it should n
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I am not sure that I like this new "platform process connect" command as it
isn't really clear what this command does. "platform connect" connects to the
remote platform, "proces
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I can't intelligently comment on low level ptrace stuff, so I will defer to
others that can.
http://reviews.llvm.org/D15042
___
lldb-commits mail
tberghammer added a comment.
I decided to go with the "platform process connect" command as it connects to
both to a platform and to a process instances at the same time but I agree it
is not very clear.
We can make this the default functionality for "platform connect" but then we
have to add
labath added a comment.
FWIW, I like Greg's idea. The operation seems quite intuitive to me: "platform
connect" connects to the platform, and if that happens to have a process ready,
then it sets that up as well..
http://reviews.llvm.org/D14952
__
Eugene.Zelenko added a comment.
I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
llvm-config from build directory. I'm not sure how well find_program will work
if path to /bin will be not added to PATH, so probably will be
good idea to allow LLVM_CONFIG to be set in Cmake co
clayborg added a comment.
I am fine with adding a new platform GDB remote packet that queries for a list
of processes that we need to connect to after we attach. It might be nice for
clients to be able to vend N number of processes that should be attached to
when the platform is connected to. T
krytarowski added a comment.
In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote:
> I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
> llvm-config from build directory. I'm not sure how well find_program will
> work if path to /bin will be not added to PATH, so p
jingham added a comment.
This looks correct, I just had a few more nits...
Comment at: source/Target/Process.cpp:3827-3828
@@ -3840,9 +3826,4 @@
-// First make sure we aren't in the middle of handling an event, or we
might restart. This is pretty weak, since
-//
This revision seems to have created a hang on startup on Windows. LLDB now
hangs during global static initialization on this line:
const ConstString
RenderScriptRuntime::Element::FallbackStructName("struct");
Perhaps its an initialization order problem?
Adrian.
On Mon, Nov 30, 2015 at 2:29 AM,
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#298830, @krytarowski wrote:
> In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote:
>
> > I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
> > llvm-config from build directory. I'm not sure how well
amccarth created this revision.
amccarth added reviewers: EwanCrawford, zturner.
amccarth added a subscriber: lldb-commits.
A previous patch introduced a global static ConstString instance. On Windows,
this results in a hang because constructing the string pool appears to depend
on other global
zturner added inline comments.
Comment at:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
-static const ConstString FallbackStructName; // Print this as the
type name of a struct Element
amccarth added inline comments.
Comment at:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
-static const ConstString FallbackStructName; // Print this as the
type name of a struct Element
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Ahh ok if there's already precedent for returning by reference then it's fine.
http://reviews.llvm.org/D15092
___
lldb-commits mailing list
lld
Author: amccarth
Date: Mon Nov 30 16:18:43 2015
New Revision: 254338
URL: http://llvm.org/viewvc/llvm-project?rev=254338&view=rev
Log:
Fix hang in global static initialization
Differential Revision: http://reviews.llvm.org/D15092
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254338: Fix hang in global static initialization (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15092?vs=41433&id=41435#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
Author: zturner
Date: Mon Nov 30 16:31:13 2015
New Revision: 254340
URL: http://llvm.org/viewvc/llvm-project?rev=254340&view=rev
Log:
Have swig_bot actually run swig, and send back the output.
Added:
lldb/trunk/scripts/swig_bot_lib/remote.py
- copied, changed from r254338, lldb/trunk/sc
Author: zturner
Date: Mon Nov 30 16:31:24 2015
New Revision: 254341
URL: http://llvm.org/viewvc/llvm-project?rev=254341&view=rev
Log:
Unpack the output on the client, completing the cycle.
Modified:
lldb/trunk/scripts/swig_bot_lib/client.py
lldb/trunk/scripts/swig_bot_lib/local.py
lld
Author: enrico
Date: Mon Nov 30 18:04:52 2015
New Revision: 254349
URL: http://llvm.org/viewvc/llvm-project?rev=254349&view=rev
Log:
Fix a bug where one-lining display of child values would ignore the user's
choice of format
Modified:
lldb/trunk/source/DataFormatters/ValueObjectPrinter.cpp
Hello everyone,
Below are some buildbot numbers for the last week of 11/22/2015 -
11/28/2015.
Thanks
Galina
Top 10 fastest builders(not docs):
lldb-amd64-ninja-freebsd11
clang-bpf-build
llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03
sanitizer-windo
Thanks for tracking these results, Galina
I think it might be better to send these to the -dev lists, rather than the
-commits lists, but I'm not sure what other people think on that.
On Mon, Nov 30, 2015 at 4:17 PM, Galina Kistanova via cfe-commits <
cfe-comm...@lists.llvm.org> wrote:
> Hello e
Hi David,
Thank you for the useful suggestions, I will work on these.
>I guess the entries with no entry in the failed column have zero failures?
Yes.
perf-x86_64-penryn-O3-polly-before-vectorizer | 31
| 31 |
perf-x86_64-penryn-O3-polly-before-vectorizer-det
On Mon, Nov 30, 2015 at 5:00 PM, Galina Kistanova
wrote:
> Hi David,
>
> Thank you for the useful suggestions, I will work on these.
>
> >I guess the entries with no entry in the failed column have zero failures?
> Yes.
>
> perf-x86_64-penryn-O3-polly-before-vectorizer |
> 31 |
jasonmolenda added a comment.
Hi Ravitheja, thanks for putting together a patch, I'm probably the best person
to look at this.
I'm not sure I understand the failure mode. When built with clang, this vdso
routine does not preserve the frame pointer register (rbp), right? If lldb
knows the sta
jasonmolenda added a comment.
Yep, Greg said the patch is good to commit.
Repository:
rL LLVM
http://reviews.llvm.org/D12877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jaydeep
Date: Mon Nov 30 23:24:17 2015
New Revision: 254376
URL: http://llvm.org/viewvc/llvm-project?rev=254376&view=rev
Log:
[LLDB][MIPS] Change ARCHFLAG for MIPS
SUMMARY:
For MIPS, ARCH is specified without m.
Reviewers: clayborg
Subscribers: nitesh.jain, mohit.bhakkad,
jaydeep closed this revision.
jaydeep added a comment.
Closed by commit http://reviews.llvm.org/rL254376
Repository:
rL LLVM
http://reviews.llvm.org/D14978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: slthakur
Date: Mon Nov 30 23:44:18 2015
New Revision: 254379
URL: http://llvm.org/viewvc/llvm-project?rev=254379&view=rev
Log:
[LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single
stepping on MIPS
This patch will clear bug 25194 - LLDB-Server Assertion raised when sing
sagar closed this revision.
sagar added a comment.
Committed in revision 254379
Repository:
rL LLVM
http://reviews.llvm.org/D14633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
41 matches
Mail list logo
