tberghammer added inline comments.
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include
-#include
+#include
I think you wanted to include , not
Comment at: source/Utility/UriParser.cpp:52-61
@@ +51,12 @@
+
Author: labath
Date: Thu Aug 20 04:06:12 2015
New Revision: 245545
URL: http://llvm.org/viewvc/llvm-project?rev=245545&view=rev
Log:
[NativeProcessLinux] Fix a bug in instruction-stepping over thread creation
Summary:
There was a bug in NativeProcessLinux, where doing an instruction-level
single
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245545: [NativeProcessLinux] Fix a bug in
instruction-stepping over thread creation (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12104?vs=32571&id=32669#toc
Repository:
rL
Author: tberghammer
Date: Thu Aug 20 04:09:01 2015
New Revision: 245546
URL: http://llvm.org/viewvc/llvm-project?rev=245546&view=rev
Log:
Improve instruction emulation based stack unwinding
On ARM there is no difference petween a pop and a load instruction so
a register can be loaded multiple tim
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245546: Improve instruction emulation based stack unwinding
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D11947?vs=32395&id=32670#toc
Repository:
rL LLVM
http://review
labath created this revision.
labath added reviewers: ovyalov, tberghammer.
labath added a subscriber: lldb-commits.
NPL used to be peppered with casts of the NativeThreadProtocol objects into
NativeThreadLinux. I
move these closer to the source where we obtain these objects. This way, the
rest
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good.
One inconsistency what might worth a change is that you usually pass NPL as a
shared_ptr (or a reference to a shared_ptr) but you created a few function
where it isn't t
Author: labath
Date: Thu Aug 20 06:37:19 2015
New Revision: 245552
URL: http://llvm.org/viewvc/llvm-project?rev=245552&view=rev
Log:
Skip TestCreateDuringInstructionStep on android aarch64
we are unable to step through _M_start_thread due to atomic instruction
sequences.
Modified:
lldb/tru
Author: labath
Date: Thu Aug 20 07:12:09 2015
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev
Log:
Increase timeout in TestCallWithTimeout to reduce flakyness
The test was flaky on the android buildbot, because the 10ms test completed
before we got a
chance to i
ovyalov added inline comments.
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include
-#include
+#include
tberghammer wrote:
> I think you wanted to include , not
I need string.h for strlen - it's required even with included
labath added a subscriber: labath.
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include
-#include
+#include
ovyalov wrote:
> tberghammer wrote:
> > I think you wanted to include , not
> I need string.h for strlen - it's requ
tberghammer added inline comments.
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include
-#include
+#include
labath wrote:
> ovyalov wrote:
> > tberghammer wrote:
> > > I think you wanted to include , not
> > I need string.h
ovyalov updated this revision to Diff 32701.
ovyalov marked an inline comment as done.
ovyalov added a comment.
Replaced #include with
http://reviews.llvm.org/D12025
Files:
source/Host/posix/ConnectionFileDescriptorPosix.cpp
source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.c
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2834
@@ -2843,3 +2833,3 @@
-NativeThreadProtocolSP thread_sp (new NativeThreadLinux (this, thread_id));
+NativeThreadLinuxSP thread_sp (new Nat
sas created this revision.
sas added reviewers: clayborg, ADodds.
sas added a subscriber: lldb-commits.
Size specifier should come after `%` not before.
http://reviews.llvm.org/D12203
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/Proces
sas created this revision.
sas added reviewers: clayborg, zturner, ADodds.
sas added a subscriber: lldb-commits.
This is useful when dealing with Windows remote that use only the
qXfer:libraries command which returns absolute base addresses, as
opposed to qXfer:libraries-svr4 which returns relativ
jingham added a subscriber: jingham.
jingham requested changes to this revision.
jingham added a reviewer: jingham.
jingham added a comment.
This revision now requires changes to proceed.
I wish we had a better abstraction for machine-specific behaviors than
ArchSpec, since it seems sad to put th
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Looks good to me, but I don't know too much about the Windows stuff. I have a
pending CL what will fix several issues related to absolute base addresses in
the DynamicLoader. If it is something what is required on Windows
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
dllexport doesn't work if linking against a static library with its own
copy of snprintf.
http://reviews.llvm.org/D12206
Files:
include/lldb/Host/windows/win32.h
source/Host/windows/Wi
looks good, can you add a comment to explain why it's inlined though.
On Thu, Aug 20, 2015 at 12:14 PM Chaoren Lin wrote:
> chaoren created this revision.
> chaoren added a reviewer: zturner.
> chaoren added a subscriber: lldb-commits.
>
> dllexport doesn't work if linking against a static libra
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: sas
Date: Thu Aug 20 15:43:29 2015
New Revision: 245608
URL: http://llvm.org/viewvc/llvm-project?rev=245608&view=rev
Log:
Fix some format strings in ProcessGDBRemote.cpp.
Summary: Size specifier should come after `%` not before.
Reviewers: clayborg, ADodds
Subscribers: lldb-commits
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245608: Fix some format strings in ProcessGDBRemote.cpp.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12203?vs=32719&id=32737#toc
Repository:
rL LLVM
http://reviews.llvm.org/
sas added a comment.
Thanks for the reviews.
I'll take a look at your change when you upload it, Tamas. Do you think I can
commit this in the meantime?
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
Author: chaoren
Date: Thu Aug 20 15:53:15 2015
New Revision: 245610
URL: http://llvm.org/viewvc/llvm-project?rev=245610&view=rev
Log:
Inline fake snprintf to avoid linkage issues on Windows.
Summary:
dllexport doesn't work if linking against a static library with its own
copy of snprintf.
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245610: Inline fake snprintf to avoid linkage issues on
Windows. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12206?vs=32722&id=32740#toc
Repository:
rL LLVM
http://revie
tberghammer added a comment.
Yes, mine is effecting the ObjectFile plugins and the DynamicLoader plugins. I
will try to upload it tomorrow
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
chying added a subscriber: chying.
chying added a comment.
It seems a bunch of darwin->android_arm tests are broken after this patch.
Could you take a look?
Here is the first build after this patch.
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4977/steps/test7/logs/stdio
Rep
sas added a comment.
Sounds good. Thanks.
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Thu Aug 20 17:07:48 2015
New Revision: 245625
URL: http://llvm.org/viewvc/llvm-project?rev=245625&view=rev
Log:
Understand absolute base addresses in ProcessGDBRemote::GetLoadedModuleList.
Summary:
This is useful when dealing with Windows remote that use only the
qXfer:libraries
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245625: Understand absolute base addresses in
ProcessGDBRemote::GetLoadedModuleList. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12204?vs=32720&id=32757#toc
Repository:
rL LL
Author: zturner
Date: Thu Aug 20 17:08:48 2015
New Revision: 245627
URL: http://llvm.org/viewvc/llvm-project?rev=245627&view=rev
Log:
XFAIL TestAnonymous.test_expr_null_with_dwarf on Windows.
This bug is tracked in llvm.org/pr21550, and also reproduces on
FreeBSD apparently.
Modified:
lldb/t
Author: zturner
Date: Thu Aug 20 17:08:38 2015
New Revision: 245626
URL: http://llvm.org/viewvc/llvm-project?rev=245626&view=rev
Log:
[ProcessWindows] Fix rare crash on shutdown.
There might be an underlying race condition here that should be
figured out, but this at least prevents the crash for
Author: zturner
Date: Thu Aug 20 17:08:57 2015
New Revision: 245628
URL: http://llvm.org/viewvc/llvm-project?rev=245628&view=rev
Log:
XFAIL TestBSDArchives.py on Windows
llvm.org/pr24527 tracks this bug. Makefile.rules does not know
how to build static libraries on Windows.
Modified:
lldb/t
Author: zturner
Date: Thu Aug 20 17:09:35 2015
New Revision: 245630
URL: http://llvm.org/viewvc/llvm-project?rev=245630&view=rev
Log:
[Windows] XFAIL tests that require calling a function in target.
This has known issues on Windows. Fixing this is tracked by
http://llvm.org/pr21765
Modified:
Author: zturner
Date: Thu Aug 20 17:09:08 2015
New Revision: 245629
URL: http://llvm.org/viewvc/llvm-project?rev=245629&view=rev
Log:
XFAIL breakpoint tests on Windows
llvm.org/pr24528 tracks fixing this test.
Modified:
lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreak
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This uses the .clang-format at the root of the LLDB repo and is just a
mechanical change that precedes more work in this file.
http://reviews.llvm.org/D12217
Files:
source/Plugins/DynamicLo
Author: zturner
Date: Thu Aug 20 17:25:45 2015
New Revision: 245631
URL: http://llvm.org/viewvc/llvm-project?rev=245631&view=rev
Log:
Change TestBSDArchives to expectedFailureWindows.
Modified:
lldb/trunk/test/functionalities/archives/TestBSDArchives.py
Modified: lldb/trunk/test/functionalit
Author: sas
Date: Thu Aug 20 17:30:20 2015
New Revision: 245634
URL: http://llvm.org/viewvc/llvm-project?rev=245634&view=rev
Log:
Run clang-format on DynamicLoaderWindowsDYLD.
Summary:
This uses the .clang-format at the root of the LLDB repo and is just a
mechanical change that precedes more work
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245634: Run clang-format on DynamicLoaderWindowsDYLD.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12217?vs=32758&id=32759#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12
sas created this revision.
sas added reviewers: clayborg, zturner, tberghammer.
sas added a subscriber: lldb-commits.
When a windows remote stops because of a DLL load/unload, the debug server
sends a stop reply packet that contains a `library` key with any value (usually
just `library:1`). This i
sas updated this revision to Diff 32766.
sas added a comment.
Fix bug with bool comparison.
http://reviews.llvm.org/D12218
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
=
Author: ovyalov
Date: Thu Aug 20 18:09:34 2015
New Revision: 245639
URL: http://llvm.org/viewvc/llvm-project?rev=245639&view=rev
Log:
Make UriParser to support [$HOSTNAME] notation.
http://reviews.llvm.org/D12025
Modified:
lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
/lldb/t
Author: jmolenda
Date: Thu Aug 20 19:13:37 2015
New Revision: 245645
URL: http://llvm.org/viewvc/llvm-project?rev=245645&view=rev
Log:
The llvm Triple for an armv6m now comes back as llvm::Triple::thumb.
This was breaking disassembly for arm machines that we force to be
thumb mode all the time bec
46 matches
Mail list logo
