Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Eric Christopher via lldb-commits
Yep yep yep. On Tue, Mar 12, 2019 at 1:24 PM Adrian Prantl via Phabricator wrote: > > aprantl added a comment. > > In D59235#1426716 , @JDevlieghere > wrote: > > > Agreed, and we've been doing this for new patches for a while now. However, > > I very str

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via lldb-commits
+1. I’ve seen some of the changes in llvm that have changed asserts to return a default value. IMHO these should be changed to return Expected instead On Tue, Mar 12, 2019 at 1:16 PM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > In D59235#

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via lldb-commits
Fair enough, a FIXME sounds reasonable. On Tue, Mar 12, 2019 at 10:33 AM Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added inline comments. > > > > Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 >uint64_t length