Re: [Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

2018-11-04 Thread Zachary Turner via lldb-commits
I tried that one and it didn’t show color, bit maybe I need to add an overload of dumpColor that allows to pass a raw_ostream On Sun, Nov 4, 2018 at 6:25 AM Raphael Isemann via Phabricator < revi...@reviews.llvm.org> wrote: > teemperor added a comment. > > I think Pavel's point is to call the `dum

Re: [Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

2018-11-04 Thread Zachary Turner via lldb-commits
The issue is that clang writes directly to stderr On Sun, Nov 4, 2018 at 5:38 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In https://reviews.llvm.org/D54072#1286748, @zturner wrote: > > > Unfortunately then color output is impossible. Where else

Re: [Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

2018-11-04 Thread Zachary Turner via lldb-commits
Ok so probably this commands output will not go to a log file when logging is enabled? I can’t think of any other side effects. Given that the immediate use case for this is interactive investigation and testing, the first of which is helped by color output and the second of which doesn’t need log

Re: [Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

2018-11-04 Thread Zachary Turner via lldb-commits
Unfortunately then color output is impossible. Where else would the output be expected to go? On Sun, Nov 4, 2018 at 2:23 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added inline comments. > > > > Comment at: lldb/source/Commands/CommandObjectTarget