Re: [Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

2017-12-06 Thread Pavel Labath via lldb-commits
On 5 December 2017 at 17:44, Greg Clayton wrote: > Didn't someone recently submit a patch to allow relocation of .o files? That > should have taken care of the issue, no? > I take it you mean D38142. This made sure that the memory we store the object file in is writable, which makes sure that we

Re: [Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

2017-12-05 Thread Greg Clayton via lldb-commits
Didn't someone recently submit a patch to allow relocation of .o files? That should have taken care of the issue, no? > On Dec 4, 2017, at 5:01 AM, Pavel Labath via lldb-commits > wrote: > > The reason you hit the assert there, is because you're running lldb on > an un-linked object file. When

Re: [Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

2017-12-04 Thread Pavel Labath via lldb-commits
The reason you hit the assert there, is because you're running lldb on an un-linked object file. When you link the file, the linker will resolve these relocations and they will disappear. This is also the reason you got those errors after removing the assert (you were trying to parse unrelocated d

Re: [Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

2017-12-01 Thread Zachary Turner via lldb-commits
On Fri, Dec 1, 2017 at 3:50 PM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham added a comment. > > Cool. We do need to make sure people don't start writing tests against it > yet, however. That would be wasted effort. > I don't think it follows that it would be a wasted