Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-30 Thread Jim Ingham via lldb-commits
> On Oct 26, 2017, at 9:34 AM, Zachary Turner > wrote: > > Note that $ is a valid character in a MSVC-mangled symbol name. So, I don't > think it will work for that reason alone. FWIW, I also don't like the {,,} > syntax very much, but if you read on there's a sim

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-26 Thread Zachary Turner via lldb-commits
Note that $ is a valid character in a MSVC-mangled symbol name. So, I don't think it will work for that reason alone. FWIW, I also don't like the {,,} syntax very much, but if you read on there's a simpler ! syntax that is pretty nice. libfoo!symbolname On Thu, Oct 26, 2017 at 9:30 AM Greg Cla

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-26 Thread Greg Clayton via lldb-commits
> On Oct 25, 2017, at 6:05 PM, Zachary Turner wrote: > > > > On Wed, Oct 25, 2017 at 4:59 PM Jim Ingham via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > jingham added a comment. > > Note, BTW, we absolutely need some way to say "this symbol from this > library". But first of al

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-25 Thread Zachary Turner via lldb-commits
On Wed, Oct 25, 2017 at 4:59 PM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham added a comment. > > Note, BTW, we absolutely need some way to say "this symbol from this > library". But first of all, if we're going to do this you need to be able > to mix & match within an

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-25 Thread Alex Langford via lldb-commits
$ nm /lib64/libm.so.6| grep " a$" 00093bb0 r a 000c6a80 r a 00093bb0 r a No, they are internal to libm only. Alex On 10/25/17, 4:15 PM, "Greg Clayton" wrote: Not hard. Just find a test that has a shared library and copy it. Modify the shared library to create a sy

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-25 Thread Greg Clayton via lldb-commits
Not hard. Just find a test that has a shared library and copy it. Modify the shared library to create a symbol named "a". Then the main executable, just run the same lambda expression and it will fail on all platforms. The current fix in the review is just for internal symbols in other shared li