This revision was automatically updated to reflect the committed changes.
Closed by commit rL280919: gdb-remote: Add jModulesInfo packet (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D24236?vs=70409&id=70671#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24236
labath added a comment.
Ok, after a bit more digging, this is what I have found:
> Error ProcessGDBRemote::GetLoadedModuleList (LoadedModuleInfoList & list);
>
This packet is not usable **in it's current form** as it does not include the
UUID of the module. As far as I can tell, it is inte
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sounds good. As long as we know what is there (the XML and Jason's other
packet) and know that the desired functionalities do not overlap I am fine with
the approach that you suggest! Than
clayborg added a comment.
Just take a look and see if there is anything worth re-using. If there is too
much mac specific stuff in there, then just use the one created, but be sure to
make it your new format completely agnostic to any platform so it can work for
anything. It is OK to include pl
labath added a reviewer: jasonmolenda.
labath added a comment.
Hm... I was not aware of that packet. It does not appear to be directly
applicable to this situation, because it queries the module information by load
address, whereas here I query by file path. Also my packet does not return the
s
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Jason Molenda already has a packet that does multiple module infos. Is this
change using his packet format? Look for "jGetLoadedDynamicLibrariesInfos". We
should try to use the s
labath updated this revision to Diff 70409.
labath added a comment.
- fix a bug where we would mark all modules as invalid if communicating with a
stub which does not support this packet
- extend the packet documentation about what to do when modules are not found
and the server volunteering inf
