This revision was automatically updated to reflect the committed changes.
Closed by commit rL254780: Implement GetMemoryRegionInfo for mini dumps.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15218?vs=41898&id=41940#toc
Repository:
rL LLVM
http://reviews.llvm.or
amccarth updated this revision to Diff 41898.
amccarth added a comment.
After discussion with Zach, we concluded that his original logic for
IsPageReadable was better.
http://reviews.llvm.org/D15218
Files:
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp
source/Plugins/Process/Windows/
amccarth updated this revision to Diff 41884.
amccarth added a comment.
Address comments.
Factored the decoding of the page protection bits to share that logic between
the live and mini dump debugging.
http://reviews.llvm.org/D15218
Files:
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cp
amccarth marked 2 inline comments as done.
amccarth added a comment.
Addressed comments.
http://reviews.llvm.org/D15218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:312
@@ +311,3 @@
+// necessary to test for any of the bits that provide that access
type.
+const bool readable =
+entry->Protect & (PA
amccarth updated this revision to Diff 41828.
amccarth added a comment.
Ran clang-format and removed initialization of a local variable that was no
longer used.
Note that clang-format re-ordered the include because the change added one
include.
http://reviews.llvm.org/D15218
Files:
source/
