ki.stfu added a comment.
lgtm
http://reviews.llvm.org/D12634
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
abidh updated this revision to Diff 34136.
abidh added a comment.
Handle review comments.
Moved the test to data directory and put it in a separate function.
http://reviews.llvm.org/D12634
Files:
test/tools/lldb-mi/data/TestMiData.py
test/tools/lldb-mi/data/main.cpp
tools/lldb-mi/MICmdCmd
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Source code looks good but please move the test to TestMiData.py.
Comment at: test/tools/lldb-mi/variable/TestMiVar.py:39-42
@@ -38,2 +38,6 @@
self.expect
