Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-25 Thread Abid, Hafiz via lldb-commits
?I will commit on your behalf. Thanks, Abid From: Tatyana Krasnukha Sent: Wednesday, May 24, 2017 6:30 PM To: Abid, Hafiz; lldb-commits@lists.llvm.org Subject: RE: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section Formatting is done

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-24 Thread Tatyana Krasnukha via lldb-commits
___ From: Tatyana Krasnukha mailto:tatyana.krasnu...@synopsys.com>> Sent: Tuesday, May 23, 2017 6:20 PM To: Abid, Hafiz; lldb-commits@lists.llvm.org<mailto:lldb-commits@lists.llvm.org> Subject: RE: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section Done. I have

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-24 Thread Abid, Hafiz via lldb-commits
To: Abid, Hafiz; lldb-commits@lists.llvm.org Subject: RE: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section Done. I have also added a little change which allow to use debug_info section when eh_frame is absent. This case really can take place on some platforms. Thanks, Tatya

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-23 Thread Tatyana Krasnukha via lldb-commits
@lists.llvm.org Subject: Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section It looks ok to me. Please put the differences of .eh_frame and .debug_frame that you described below in code comments too.​ Thanks, Abid From: lldb-commits

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-23 Thread Abid, Hafiz via lldb-commits
@lists.llvm.org Subject: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section Fix FDE indexing while scan debug_info section. There are some differences between eh_frame and debug_frame formats that are not considered by DWARFCallFrameInfo::GetFDEIndex. An FDE entry contains

[Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-18 Thread Tatyana Krasnukha via lldb-commits
Fix FDE indexing while scan debug_info section. There are some differences between eh_frame and debug_frame formats that are not considered by DWARFCallFrameInfo::GetFDEIndex. An FDE entry contains CIE_pointer in debug_frame in same place as cie_id in eh_frame. As described in dwarf standard