Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

2018-12-04 Thread Jonas Devlieghere via lldb-commits
Yeah, that's a good idea. Made the change in r348289. On Tue, Dec 4, 2018 at 2:55 AM Pavel Labath wrote: > On 03/12/2018 21:55, Jonas Devlieghere via lldb-commits wrote: > > That wouldn't work because we try to create the directory which would > > succeeded in the temp dir. I'd have to be someth

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

2018-12-04 Thread Pavel Labath via lldb-commits
On 03/12/2018 21:55, Jonas Devlieghere via lldb-commits wrote: That wouldn't work because we try to create the directory which would succeeded in the temp dir. I'd have to be something you don't have access to, like the root or some network drive. How about we change the behavior to only cre

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

2018-12-03 Thread Zachary Turner via lldb-commits
I will just add that once upon a time, there was a test in LLVM that worked similar to this, and so it would try to open a file like /foo/foo.txt, and expect it to fail (meaning that if it succeeded, the test would fail). I had once created that file on my hard drive by pure coincidence, and so th

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

2018-12-03 Thread Jonas Devlieghere via lldb-commits
That wouldn't work because we try to create the directory which would succeeded in the temp dir. I'd have to be something you don't have access to, like the root or some network drive. On Mon, Dec 3, 2018 at 12:53 PM Zachary Turner wrote: > Perhaps use %t.bogus? instead of /bogus? > > On Mon, De

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

2018-12-03 Thread Zachary Turner via lldb-commits
Perhaps use %t.bogus? instead of /bogus? On Mon, Dec 3, 2018 at 12:39 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jdevlieghere > Date: Mon Dec 3 12:36:21 2018 > New Revision: 348186 > > URL: http://llvm.org/viewvc/llvm-project?rev=348186&view=rev > Log:

[Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

2018-12-03 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Dec 3 12:36:21 2018 New Revision: 348186 URL: http://llvm.org/viewvc/llvm-project?rev=348186&view=rev Log: Skip TestDriverOptions on Windows It's not clear to me why this is failing on Windows. Maybe it has something to do with the path? Modified: lldb/trunk/l