Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

2018-06-21 Thread Pavel Labath via lldb-commits
Thanks for the explanation. The ifdef parts should be reverted by r335236. On Thu, 21 Jun 2018 at 18:39, Greg Clayton wrote: > > > > > On Jun 21, 2018, at 10:30 AM, Pavel Labath via lldb-commits > > wrote: > > > > Sure, I can do that. The though of xcode compatibility did enter my > > mind brie

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

2018-06-21 Thread Greg Clayton via lldb-commits
> On Jun 21, 2018, at 10:30 AM, Pavel Labath via lldb-commits > wrote: > > Sure, I can do that. The though of xcode compatibility did enter my > mind briefly while doing this, but I just assumed that XCode always > builds with python enabled. I guess I was wrong. > > Out of curiosity, what ar

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

2018-06-21 Thread Pavel Labath via lldb-commits
Sure, I can do that. The though of xcode compatibility did enter my mind briefly while doing this, but I just assumed that XCode always builds with python enabled. I guess I was wrong. Out of curiosity, what are you using the !Python build for? On Thu, 21 Jun 2018 at 18:16, Jim Ingham wrote: > >

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

2018-06-21 Thread Jim Ingham via lldb-commits
This change will break building from Xcode without Python. It will take a bunch of monkeying with the project files to achieve the same effect as your cmake changes, and I don't have time to do that right now. I have no problem with changing cmake to just not build the relevant files, but can

[Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

2018-06-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 21 07:09:15 2018 New Revision: 335236 URL: http://llvm.org/viewvc/llvm-project?rev=335236&view=rev Log: ScriptInterpreterPython cleanup Instead of #ifdef-ing the contents of all files in the plugin for all non-python builds, just disable the plugin at the cmake level.