Re: [Lldb-commits] [lldb] r320456 - Avoid module import in a textual header, NFC

2017-12-13 Thread Vedant Kumar via lldb-commits
Ah sorry, didn't see this for a while! Yes -- I agree on both points here. vedant > On Dec 11, 2017, at 9:07 PM, Zachary Turner wrote: > > Long term it would be nice if we could get all these register definitions > automatically generated with llvm-tblgen. That's a big undertaking, though. >

Re: [Lldb-commits] [lldb] r320456 - Avoid module import in a textual header, NFC

2017-12-11 Thread Zachary Turner via lldb-commits
Long term it would be nice if we could get all these register definitions automatically generated with llvm-tblgen. That's a big undertaking, though. On Mon, Dec 11, 2017 at 7:27 PM Vedant Kumar via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: vedantk > Date: Mon Dec 11 19:27:13

[Lldb-commits] [lldb] r320456 - Avoid module import in a textual header, NFC

2017-12-11 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Mon Dec 11 19:27:13 2017 New Revision: 320456 URL: http://llvm.org/viewvc/llvm-project?rev=320456&view=rev Log: Avoid module import in a textual header, NFC This unbreaks the lldb modules build (-DLLVM_ENABLE_MODULES=On). Modified: lldb/trunk/source/Plugins/Process/Util