Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-04 Thread Stephane Sezer via lldb-commits
Yeah, just a quick note about ds2, this is the current status of supported platforms: * Linux (x86/x86_64/arm/aarch64), used for debugging processes on "classic" linux (Ubuntu, centOS, etc), Android, as well as Tizen. * Windows (x86/x86_64/arm), used to debug processes on Windows Desktop, Windows P

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Jim Ingham via lldb-commits
Yeah, I was not being realistic in saying that. debugserver has a bunch of junk in it specific to our various embedded platforms that isn't actually buildable outside of Apple, but which we need (it's all #ifdef around in the debugserver sources). We aren't going to be able to do away with thi

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Zachary Turner via lldb-commits
There was also some discussion from some Facebook people about using their own in-house ds2. It sounds like a large effort, but IIUC it's compatible with debugserver, and supports more platforms than lldb-server. +stephane and saleem since they know more about it. Actually, +greg too since I gue

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Jim Ingham via lldb-commits
If somebody finds themselves ambitious to work on debugserver, they should divert that energy to porting lldb-server to macOS IMHO. Jim > On Dec 1, 2017, at 4:04 PM, Jim Ingham wrote: > > Yes, we don't use llvm code in debugserver. It doesn't actually use any lldb > classes either, it's its

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Jim Ingham via lldb-commits
Yes, we don't use llvm code in debugserver. It doesn't actually use any lldb classes either, it's its own standalone thing. Jim > On Dec 1, 2017, at 4:01 PM, Zachary Turner via lldb-commits > wrote: > > I don't recall, is there a hard restriction on debugserver not being allowed > to use l

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Zachary Turner via lldb-commits
I don't recall, is there a hard restriction on debugserver not being allowed to use llvm code? Because YAML is a superset of JSON On Fri, Dec 1, 2017 at 3:36 PM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Also, FWIW, this is blatantly not the correct way of using ass

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Davide Italiano via lldb-commits
Also, FWIW, this is blatantly not the correct way of using assertions. It should either be assert(false && "patatino") or the more canonical llvm_unreachable("patatino"). Relying on the implicit conversion from string to bool seems risky (and not really useful). On Fri, Dec 1, 2017 at 3:29 PM, Ved

[Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

2017-12-01 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Fri Dec 1 15:29:04 2017 New Revision: 319596 URL: http://llvm.org/viewvc/llvm-project?rev=319596&view=rev Log: Fix warnings in JSON.cpp, NFC These asserts are no-ops, and are supplanted by -Wcovered-switch. Modified: lldb/trunk/tools/debugserver/source/JSON.cpp Modifi