Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

2016-08-30 Thread Greg Clayton via lldb-commits
> On Aug 30, 2016, at 6:32 AM, Pavel Labath wrote: > > I think we should move the new file away from source/Utility. If it's > supposed to be used by debugserver only, we probably should move it to > tools/debugserver/source ? Right now, debugservers cmake file contains > a hack to be able to in

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

2016-08-30 Thread Pavel Labath via lldb-commits
I've seen that one. What kind of changes do you have in mind? I am not sure how these things are related, as the StdString version is already being used only by debugserver (*), and you don't plan to make changes to it (afaik). (*) $ git grep -l -w StdStringExtractor include/lldb/Utility/StdString

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

2016-08-30 Thread Zachary Turner via lldb-commits
Yes, there was a thread on lldb dev about it. After i get all the changes in to the newer one we can move the old one out On Tue, Aug 30, 2016 at 6:32 AM Pavel Labath wrote: > I think we should move the new file away from source/Utility. If it's > supposed to be used by debugserver only, we proba

Re: [Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

2016-08-30 Thread Pavel Labath via lldb-commits
I think we should move the new file away from source/Utility. If it's supposed to be used by debugserver only, we probably should move it to tools/debugserver/source ? Right now, debugservers cmake file contains a hack to be able to include these, so by doing that we will remove that as well. Thou

[Lldb-commits] [lldb] r279997 - Copy StringExtractor to StdStringExtractor.

2016-08-29 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Aug 29 14:45:59 2016 New Revision: 279997 URL: http://llvm.org/viewvc/llvm-project?rev=279997&view=rev Log: Copy StringExtractor to StdStringExtractor. I have some improvements to make to StringExtractor that require using LLVM. debugserver can't take a dependency on LL