Re: [Lldb-commits] [lldb] r258586 - More fixes related to counting threads on Windows.

2016-01-22 Thread Jim Ingham via lldb-commits
That would be fine as an additional test. There isn't an SBThread::SetName, but that would be trivial to add. Also, if we are going to rely on this, we should improve how SetName is done. Right now the default implementation does nothing, so it relies on the particular implementation to se

Re: [Lldb-commits] [lldb] r258586 - More fixes related to counting threads on Windows.

2016-01-22 Thread Zachary Turner via lldb-commits
By the way, I'm reminded of a discussion we had on an old bug report where we said that an even better way to do this would be to name threads from inside the debugger and have the test fetch threads with specific names. That's probably still a better way to do this (especially when multiple thread

Re: [Lldb-commits] [lldb] r258586 - More fixes related to counting threads on Windows.

2016-01-22 Thread Zachary Turner via lldb-commits
Yea, that's a good idea. Thanks for the suggestion On Fri, Jan 22, 2016 at 4:05 PM Jim Ingham wrote: > Would you mind adding a comment telling people how to do this correctly to > the "Writing test cases" section of the README-testsuite? > > Jim > > > On Jan 22, 2016, at 3:54 PM, Zachary Turner

Re: [Lldb-commits] [lldb] r258586 - More fixes related to counting threads on Windows.

2016-01-22 Thread Jim Ingham via lldb-commits
Would you mind adding a comment telling people how to do this correctly to the "Writing test cases" section of the README-testsuite? Jim > On Jan 22, 2016, at 3:54 PM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date: Fri Jan 22 17:54:41 2016 > New Revision: 258586 > > URL

[Lldb-commits] [lldb] r258586 - More fixes related to counting threads on Windows.

2016-01-22 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Jan 22 17:54:41 2016 New Revision: 258586 URL: http://llvm.org/viewvc/llvm-project?rev=258586&view=rev Log: More fixes related to counting threads on Windows. The Windows 10 loader spawns threads at startup, so tests which count threads or assume that a given user thread