Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Enrico Granata via lldb-commits
> On Sep 23, 2015, at 12:09 PM, Ed Maste wrote: > > I'd suggest we revert for now and bring it back after testing on all > platforms. There were a couple of nits and changes in the committed > version relative to the version in the review as well so I think it's > better to bring it back with th

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Ed Maste via lldb-commits
I'd suggest we revert for now and bring it back after testing on all platforms. There were a couple of nits and changes in the committed version relative to the version in the review as well so I think it's better to bring it back with those fixed up. On 23 September 2015 at 14:52, Enrico Granata

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Enrico Granata via lldb-commits
I am seeing the same issue on OS X Ravitheja, can you investigate this? Or should we just revert? > On Sep 23, 2015, at 9:54 AM, Ed Maste via lldb-commits > wrote: > > On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits > wrote: >> Author: ravitheja >> Date: Wed Sep 23 02:19:0

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Ed Maste via lldb-commits
On 23 September 2015 at 03:19, Ravitheja Addepally via lldb-commits wrote: > Author: ravitheja > Date: Wed Sep 23 02:19:02 2015 > New Revision: 248366 > > URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev > Log: > Testcase and fix for bug 24074 This change introduced a segfault in 10 o

Re: [Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Ryan Brown via lldb-commits
The doc comment for SortTypeList() is wrong. On Sep 23, 2015 12:20 AM, "Ravitheja Addepally via lldb-commits" < lldb-commits@lists.llvm.org> wrote: > Author: ravitheja > Date: Wed Sep 23 02:19:02 2015 > New Revision: 248366 > > URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev > Log: >

[Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Sep 23 02:19:02 2015 New Revision: 248366 URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev Log: Testcase and fix for bug 24074 Summary: In bug 24074, the type information is not shown correctly. This commit includes the following - -> Changes for displayin