https://github.com/labath commented:
Seems ok to me.
If I had to guess, I'd say that the initial stop problem is due to us stopping
the process "too early" (i.e., in a state where it's not yet fully initialized
and ready to accept debugger commands). Maybe there's a different way to stop
the
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -178,9 +178,41 @@ Status NativeThreadWindows::RemoveWatchpoint(lldb::addr_t
addr) {
Status NativeThreadWindows::SetHardwareBreakpoint(lldb::addr_t addr,
size_t size) {
+#if defined(__aarch64__) || defined(_M_ARM64)
jasonmolenda wrote:
i skimmed the patch, I didn't see anything that concerns me. The fact that we
can't query the number of hardware watchpoints/breakpoints means that this code
will misbehave on other platforms where the numbers are different - we might
have four hardware watchpoints, but yo
https://github.com/omjavaid updated
https://github.com/llvm/llvm-project/pull/108072
>From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001
From: Muhammad Omair Javaid
Date: Tue, 10 Sep 2024 18:03:29 +0500
Subject: [PATCH] WoA hardware breakpoint/watchpoint support
---
.../Wi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5537ae87b3a87b3abeb4e6983cecd9b103648243
1c29d30f0b9eb47da63c35f775ad69e1ef40c4de --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Omair Javaid (omjavaid)
Changes
This pull request adds support for hardware breakpoints and watchpoints in LLDB
on Windows on ARM.
### Known Issues:
1. **Number of Supported Hardware Breakpoints/Watchpoints:** Windows does not
provide th
https://github.com/omjavaid created
https://github.com/llvm/llvm-project/pull/108072
This pull request adds support for hardware breakpoints and watchpoints in LLDB
on Windows on ARM.
### Known Issues:
1. **Number of Supported Hardware Breakpoints/Watchpoints:** Windows does not
provide the
