[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/114251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Think the intention was to originally make sure that we're debugging libc++. Checking this here is unnecessary (and should really be asserted at the Makefile layer, which do on Apple platforms) https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. --- Full diff: https://github.com/llvm/llvm-project/pull/114251.dif

[Lldb-commits] [lldb] Remove a flaky and unnecessary check (PR #114251)

2024-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/114251 The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. >From 553d4742e6972a068105177aafd47b3da2c01d8f Mon Sep 17 00:00:00 200