https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/141529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/141529
>From 0f5a95ebe67f54ba7dfe55ff8450226ba84f113d Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 26 May 2025 22:25:05 +0200
Subject: [PATCH] [lldb-dap] Treat empty thread names as unset
---
lldb/test/API/tools
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/141529
>From 2f597d5b2355d7b786d76457ca3435f6cd577e3e Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 26 May 2025 22:25:05 +0200
Subject: [PATCH] [lldb-dap] Treat empty thread names as unset
---
lldb/test/API/tools
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py
``
View
Nerixyz wrote:
> The launch sequence is in parallel. Is it possible that the two debug adapter
> implements are handling them in different orders? It took me a while to
> realize this. I found this diagram enlightening: [microsoft/vscode#4902
> (comment)](https://github.com/microsoft/vscode/is
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/141529
>From 2a79486c4d45a8b4251ad32cd0629473c4ce828d Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 26 May 2025 22:25:05 +0200
Subject: [PATCH] [lldb-dap] Treat empty thread names as unset
---
lldb/test/API/tools
JDevlieghere wrote:
> > (on Windows)?
>
> That's the hard part 😅. I tried to get
> https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py
> to run on Windows, but it's too flaky. From my observation, the debug
> adapter is too fast at launching
Nerixyz wrote:
>(on Windows)?
That's the hard part 😅. I tried to get
https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py
to run on Windows, but it's too flaky. From my observation, the debug adapter
is too fast at launching the program before
JDevlieghere wrote:
The change looks reasonable. Can we test this (on Windows)?
https://github.com/llvm/llvm-project/pull/141529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/141529
When a target thread returned an empty but not `nullptr` string as its name,
the thread would show up with an empty name in lldb-dap.
I don't know how this works on macOS and Linux, but on Windows,
[`TargetThr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
When a target thread returned an empty but not `nullptr` string as its name,
the thread would show up with an empty name in lldb-dap.
I don't know how this works on macOS and Linux, but on Windows,
[`TargetThreadWi
11 matches
Mail list logo
