[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-12 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @ashgti @walter-erquinigo could you take another look at this PR? Afaict, all comments should be addressed and this PR is (hopefully) ready to be merged https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-12 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Looks great! https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-12 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { +

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-12 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { -

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-12 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/125843 >From 48e900c6a8bd24c7cbee057eb0d96b9f0b2b4f84 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 5 Feb 2025 10:11:38 + Subject: [PATCH 1/4] [lldb-dap] Support vscode launch URLs This commit

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { -

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/125843 >From 48e900c6a8bd24c7cbee057eb0d96b9f0b2b4f84 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 5 Feb 2025 10:11:38 + Subject: [PATCH 1/3] [lldb-dap] Support vscode launch URLs This commit

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread John Harrison via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { -

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Thanks. I updated the PR with your suggestions. I will keep the PR open for a couple more days, in case other reviewers also have comments https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/125843 >From cd525991ef676df7108e825eff35610638f8d7ea Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 5 Feb 2025 10:11:38 + Subject: [PATCH 1/2] [lldb-dap] Support vscode launch URLs This commit

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! LGTM with small nits. https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
@@ -174,6 +174,20 @@ The default hostname being used `localhost`. } ``` +### Launching via `vscode://` URIs + +Debugging sessions can also be starting using special URIs. + +The `vscode://llvm-vs-code-extensions.lldb-dap/launch/config?config={launch-config}` +URI accepts a [U

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { +

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/125843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-02-05 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Here is a screen recording https://github.com/user-attachments/assets/2092beca-3c52-4395-93a6-cf6ad16d1178 and the [example script](https://gist.github.com/vogelsgesang/572b04dc1d447776964fb7e40fd8b261). Note that I had to launch my program using `${CWD}/a.out` instead