ashgti wrote:
FYI, I am not a code owner of lldb-dap or lldb. I think its usually best to
wait for one of the owners to sign off before submitting.
See https://github.com/llvm/llvm-project/blob/main/lldb/Maintainers.md for the
full list of active maintainers.
https://github.com/llvm/llvm-proj
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 4
"build".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/9140
Here is the relevant piece of
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win`
running on `as-builder-10` while building `lldb` at step 8 "build-default".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/197/builds/6086
Here is the relevant piece of the bui
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/12] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/11] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/10] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/9] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/8] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
eronnen wrote:
oh, yeah I can move it
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
ashgti wrote:
I meant should the file be `lldb/tools/lldb-dap/ProtocolUtils.{h,cpp}`
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -139,15 +141,16 @@ static DisassembledInstruction
ConvertSBInstructionToDisassembledInstruction(
disassembled_inst.instruction = std::move(instruction);
- auto line_entry = addr.GetLineEntry();
+ auto source = CreateSource(addr, target);
+ auto line_entry = GetLineEn
@@ -0,0 +1,17 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/7] Reuse creation of Source objects for assembly and normal
sourc
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -139,15 +141,16 @@ static DisassembledInstruction
ConvertSBInstructionToDisassembledInstruction(
disassembled_inst.instruction = std::move(instruction);
- auto line_entry = addr.GetLineEntry();
+ auto source = CreateSource(addr, target);
+ auto line_entry = GetLineEn
@@ -0,0 +1,17 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/6] Reuse creation of Source objects for assembly and normal
sourc
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/tools/lldb-dap/Protocol/ProtocolUtils.cpp
lld
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/5] Reuse creation of Source objects for assembly and normal
sourc
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 4c20703077eb4bbee8cfeb59022dec89d8697d83 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal
sourc
eronnen wrote:
Currently I don't think it can live in lldb-dap, because both setting the
target and calculating the symbol context are private:
```cpp
sc.target_sp = target.GetSP();
SymbolContextItem scope = static_cast(resolve_scope);
if (m_opaque_up->IsVal
eronnen wrote:
Looking at the `SBTarget::ResolveSymbolContextForAddress()` implementation it
won't apply source maps correctly because it doesn't set the target to the
symbol context at any point. in order to apply the source maps you must have
`sc.target_sp
ashgti wrote:
nit: Should this live in the lldb-dap top level folder? I could go either way
on that, but it matches the existing helpers.
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal
sourc
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/3] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -317,6 +317,8 @@ struct Source {
std::optional presentationHint;
// unsupported keys: origin, sources, adapterData, checksums
+
+ bool IsAssemblySource() const { return sourceReference.value_or(0) != 0; }
eronnen wrote:
:100:
https://github.com/llvm
@@ -558,28 +558,38 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -252,4 +252,11 @@ std::string GetSBFileSpecPath(const lldb::SBFileSpec
&file_spec) {
return path;
}
+lldb::SBLineEntry GetLineEntryForAddress(lldb::SBTarget &target,
+ lldb::SBAddress &address) {
+ lldb::SBSymbolContext sc =
+
@@ -250,14 +252,16 @@ protocol::Source CreateSource(const lldb::SBFileSpec
&file);
/// Create a "Source" JSON object as described in the debug adapter definition.
///
-/// \param[in] line_entry
-/// The LLDB line table to use when populating out the "Source"
-/// obje
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/2] Reuse creation of Source objects for assembly and normal
sourc
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
Refactor code revolving source objects such that most logics will be reused.
The main change is to expose a single `CreateSource(addr, target)` that can
return either a normal or an assembly source object, an
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/141426
Refactor code revolving source objects such that most logics will be reused.
The main change is to expose a single `CreateSource(addr, target)` that can
return either a normal or an assembly source object, an
59 matches
Mail list logo
