[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From fc5e5e4d10f15608cc7727b5ad6af6237417d36c Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread via lldb-commits
@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread David Peixotto via lldb-commits
@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: We (Linaro) are seeing the same error message with a different test on our AArch64 Linux bot: ``` ERROR: test_indexedVariables_with_raw_child_for_synthetics (TestDAP_variables.TestDAP_variables) -- Tracebac

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits
https://github.com/dmpots requested changes to this pull request. https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits
@@ -374,6 +374,15 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread Jonas Devlieghere via lldb-commits
@@ -374,6 +374,15 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM! I'm not too familiar with the dap protocol, so would be good to get another approver. https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From 951b49b11f958b68b65a480be3cb12eb8feb2dcf Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits
@@ -374,6 +374,12 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_process_and_initialized(self, timeout=None): dmpots wrote: You are taking `timeout` as a parameter here, but not passing it down to

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
@@ -612,7 +612,16 @@ def request_attach( if gdbRemoteHostname is not None: args_dict["gdb-remote-hostname"] = gdbRemoteHostname command_dict = {"command": "attach", "type": "request", "arguments": args_dict} -return self.send_recv(command_di

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
@@ -612,7 +612,16 @@ def request_attach( if gdbRemoteHostname is not None: args_dict["gdb-remote-hostname"] = gdbRemoteHostname command_dict = {"command": "attach", "type": "request", "arguments": args_dict} -return self.send_recv(command_di

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/2] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From b5e0b6e31a6bd2145fce2f87200d1220627df9a6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/2] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes This patch makes the `request_attach` wait for events `process` and `initialized` just like `request_launch`. This ensure the DAP session can move forward somewhat correctly. Recently `TestDap_attach.test_terminate

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-24 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/137278 This patch makes the `request_attach` wait for events `process` and `initialized` just like `request_launch`. This ensure the DAP session can move forward somewhat correctly. Recently `TestDap_attach.test_term