[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-04-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15220 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/133811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread John Harrison via lldb-commits
@@ -571,7 +571,7 @@ int main(int argc, char *argv[]) { } lldb::IOObjectSP input = std::make_shared( - fileno(stdin), File::eOpenOptionReadOnly, true); + fileno(stdin), File::eOpenOptionReadOnly, false); ashgti wrote: Applied. https://github.com

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/133811 >From 9053618204265ea71a6a30382937cff584f8c02d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 31 Mar 2025 14:36:16 -0700 Subject: [PATCH 1/2] [lldb-dap] Do not take ownership of stdin. There isn't any b

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes There isn't any benefit to taking ownership of stdin and it may cause issues if `Transport` is dealloced. --- Full diff: https://github.com/llvm/llvm-project/pull/133811.diff 1 Files Affected: - (modified)

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread Jonas Devlieghere via lldb-commits
@@ -571,7 +571,7 @@ int main(int argc, char *argv[]) { } lldb::IOObjectSP input = std::make_shared( - fileno(stdin), File::eOpenOptionReadOnly, true); + fileno(stdin), File::eOpenOptionReadOnly, false); JDevlieghere wrote: ```suggestion fi

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Do not take ownership of stdin. (PR #133811)

2025-03-31 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/133811 There isn't any benefit to taking ownership of stdin and it may cause issues if `Transport` is dealloced. >From 9053618204265ea71a6a30382937cff584f8c02d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 3