llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
Improving logging by defining new helpers for more uniform log handling. This
should help us clearly identify log messages and helps abstract the underlying
log type within the macro in case we want to update
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/130653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130653
>From 88f1cf3469c9f24a768f5147c22cfe414aea014e Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Sat, 8 Mar 2025 17:55:34 -0800
Subject: [PATCH 1/3] [lldb-dap] Adding logging helpers.
Improving logging by defin
@@ -711,22 +700,15 @@ PacketStatus DAP::GetNextObject(llvm::json::Object
&object) {
llvm::StringRef json_sref(json);
llvm::Expected json_value = llvm::json::parse(json_sref);
- if (auto error = json_value.takeError()) {
-std::string error_str = llvm::toString(std::mo
@@ -239,14 +241,7 @@ void DAP::SendJSON(const llvm::json::Value &json) {
std::lock_guard locker(mutex);
SendJSON(json_str);
- if (log) {
-auto now = std::chrono::duration(
-std::chrono::system_clock::now().time_since_epoch());
-*log << llvm::formatv("{0:f9
@@ -239,14 +241,7 @@ void DAP::SendJSON(const llvm::json::Value &json) {
std::lock_guard locker(mutex);
SendJSON(json_str);
- if (log) {
-auto now = std::chrono::duration(
-std::chrono::system_clock::now().time_since_epoch());
-*log << llvm::formatv("{0:f9
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/130653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -711,22 +700,15 @@ PacketStatus DAP::GetNextObject(llvm::json::Object
&object) {
llvm::StringRef json_sref(json);
llvm::Expected json_value = llvm::json::parse(json_sref);
- if (auto error = json_value.takeError()) {
-std::string error_str = llvm::toString(std::mo
