https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/142129
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/142129
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -23,15 +19,23 @@ def test_disassemble(self):
self.set_source_breakpoints(source, [line_number(source, "//
breakpoint 1")])
self.continue_to_next_stop()
-_, pc_assembly = self.disassemble(frameIndex=0)
-self.assertIn("location", pc_assembly,
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/142129
>From 4c0bd999e60b7082fb30916c5f20d7ab064e76fe Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Fri, 30 May 2025 12:49:22 +0100
Subject: [PATCH 1/2] [lldb-dap][test] Fix DAP disassemble test
compare the instru
@@ -23,15 +19,23 @@ def test_disassemble(self):
self.set_source_breakpoints(source, [line_number(source, "//
breakpoint 1")])
self.continue_to_next_stop()
-_, pc_assembly = self.disassemble(frameIndex=0)
-self.assertIn("location", pc_assembly,
https://github.com/ashgti commented:
Can we also move
https://github.com/llvm/llvm-project/blob/f7e172da4caeab9d92f6e97501b1a2c561e616c1/lldb/test/API/tools/lldb-dap/disassemble/main.c#L9
to line 11?
That should help us land on a location with a line associated with it.
https://github.com/llv
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/142129
compare the instructions before and after setting breakpoint to make sure they
are the same.
Do not use the source location as it is not guaranteed to exist.
>From 4c0bd999e60b7082fb30916c5f20d7ab064e76fe Mon
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
compare the instructions before and after setting breakpoint to make sure they
are the same.
Do not use the source location as it is not guaranteed to exist.
---
Full diff: https://github.com/llvm/llvm-proje
