[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
dlav-sc wrote: > Looks good to me. Thank you for the review. I haven't merge rights yet, so could you press the button, please. https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-19 Thread David Spickett via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-18 Thread via lldb-commits
dlav-sc wrote: > Sure, please update the PR title and description to reflect that, then I'll > take a look. Thanks https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-18 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-18 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits