[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
@@ -1,5 +1,6 @@ add_lldb_unittest(APITests SBCommandInterpreterTest.cpp +SBLineEntryTest.cpp JDevlieghere wrote: ```suggestion SBLineEntryTest.cpp ``` https://github.com/llvm/llvm-project/pull/130435 ___

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130435 >From 02c34e87db59a0b87887aba479afbab70925241b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sat, 8 Mar 2025 19:47:17 + Subject: [PATCH 1/3] [lldb] fix set SBLineEntryColumn --- lldb/source/API/SBLineE

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-09 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130435 >From 02c34e87db59a0b87887aba479afbab70925241b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sat, 8 Mar 2025 19:47:17 + Subject: [PATCH 1/2] [lldb] fix set SBLineEntryColumn --- lldb/source/API/SBLineE

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (Da-Viper) Changes Calling the public API `SBLineEntry::SetColumn()` sets the row instead of the column. This probably should be backported as it has been since version 3.4. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-08 Thread via lldb-commits
https://github.com/Da-Viper created https://github.com/llvm/llvm-project/pull/130435 Calling the public API `SBLineEntry::SetColumn()` sets the row instead of the column. This probably should be backported as it has been since version 3.4. >From 02c34e87db59a0b87887aba479afbab70925241b Mon