llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/6383
Here is the relevant piece of t
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 01/10] [lldb] Support stepping over C++ thunks
This PR
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/9] [lldb] Support stepping over C++ thunks
This PR fi
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/8] [lldb] Support stepping over C++ thunks
This PR fi
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/7] [lldb] Support stepping over C++ thunks
This PR fi
@@ -476,3 +476,12 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ // Virtual function override thunks come in two forms. Those overriding from
a
+ // non
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Nice! LGTM with comment.
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -76,6 +77,18 @@ bool ThreadPlanShouldStopHere::DefaultShouldStopHereCallback(
}
}
+ // Check whether the frame we are in is a language runtime thunk, only for
+ // step out:
+ if (operation == eFrameCompareOlder) {
+Symbol *symbol = frame->GetSymbolContext(eSym
jimingham wrote:
This looks fine.
The one thing that we might want to also test is that if we step through the
thunk, and then stop in some code that we don't want to stop in (i.e. the
target of the thunk doesn't have debug information) we step back out correctly.
This should work by compo
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/5] [lldb] Support stepping over C++ thunks
This PR fi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6812fc02fbb81d679f95d5c3e15768ae11e1bad8
b5904f01c64b2c6005f986886ce00ac507172bd2 --e
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/4] [lldb] Support stepping over C++ thunks
This PR fi
@@ -476,3 +476,12 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ // Virtual function override thunks come in two forms. Those overriding from
a
+ // non
tedwoodward wrote:
@JDevlieghere would you mind getting rid of the nullptr in the testcase,
main.cpp line 13?
Base2 *b = nullptr;
*b is set to nullptr per language standard, and those of use stuck in c++03 on
embedded targets would appreciate it!
https://github.com/llvm/llvm-project/pull/1274
Michael137 wrote:
Makes sense to me but I'll defer to @jimingham and co. for the stepping bits
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
levy wrote:
I'm the one who recently added an example reproducing the #43413 issue. I
compiled this PR version of lldb and related tools and tested it against the
simple reproduction I added to the issue, and also with our complex project
where I first faced this issue. In both cases lldb work
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/2] [lldb] Support stepping over C++ thunks
This PR fi
@@ -476,3 +476,9 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ llvm::outs() << symbol.GetMangled().GetMangledName().GetStringRef() << '\n';
+ return sym
@@ -476,3 +476,9 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ llvm::outs() << symbol.GetMangled().GetMangledName().GetStringRef() << '\n';
-
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
25 matches
Mail list logo
