[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/4279 Here is the relevant piece of the bu

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/105765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

jasonmolenda wrote: @clayborg what do you think about removing the memory limit from memory read? I know this is code you originally wrote, and I might not be thinking of a way for someone to do a huge memory read unintentionally. But it seems like this cap just gets in people's way more tha

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105765 >From 6a27ad3be748a6072014a805a5a94dede9321432 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 22 Aug 2024 18:29:55 -0700 Subject: [PATCH 1/2] [lldb] Remove limit on max memory read size `memory re

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

jasonmolenda wrote: > > both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I > > could have sworn the only test failure I had before was in > > TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test > > case. Hmm. > > I believe that failure is unrelated to yo

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

medismailben wrote: > both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I could > have sworn the only test failure I had before was in > TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test case. > Hmm. I believe that failure is unrelated to your PR since

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

jasonmolenda wrote: both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I could have sworn the only test failure I had before was in TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test case. Hmm. https://github.com/llvm/llvm-project/pull/105765

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/105765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

jasonmolenda wrote: Updated patch to a hex constant in the .td file as per Ismail's suggestion, fixed the new TestMemoryReadMaximumSize.py test to work with the new default. https://github.com/llvm/llvm-project/pull/105765 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105765 >From 6a27ad3be748a6072014a805a5a94dede9321432 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 22 Aug 2024 18:29:55 -0700 Subject: [PATCH 1/2] [lldb] Remove limit on max memory read size `memory re

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

@@ -102,7 +102,7 @@ let Definition = "target" in { DefaultUnsignedValue<1024>, Desc<"Maximum number of characters to show when using %s in summary strings.">; def MaxMemReadSize: Property<"max-memory-read-size", "UInt64">, -DefaultUnsignedValue<1024>, +Defaul

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

jasonmolenda wrote: lol my hubris is on display, the PR testing hit a test failure in ... TestMemoryReadMaximumSize.py which I wrote & merged earlier today, and assumes there is a limit of 1024. ;) https://github.com/llvm/llvm-project/pull/105765 __

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

jasonmolenda wrote: (the setting is a UInt64, but Target.cpp reads it and returns a uint32_t, so I only did UINT32_MAX value) https://github.com/llvm/llvm-project/pull/105765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes `memory read` will return an error if you try to read more than 1k bytes in a single command, instructing you to set `target.max-memory-read-size` or use `--force` if you intended to read more than that

[Lldb-commits] [lldb] [lldb] Remove limit on max memory read size (PR #105765)

https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/105765 `memory read` will return an error if you try to read more than 1k bytes in a single command, instructing you to set `target.max-memory-read-size` or use `--force` if you intended to read more than that.