[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

https://github.com/labath approved this pull request. Yes, that looks about right, though it's unfortunate that this does not have any test case. I would really recommend you figure out a testing strategy for this -- for your benefit (less chance of other changes breaking this use case) if no

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

GeorgeHuyubo wrote: > > Updated the commit to address @labath's comment. > > Can you explain how you did that? The new implementation does something > completely different (and wrong on several levels) from the one I pointed you > to. > [Here](https://android.googlesource.com/platform/bionic/

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/120655 >From 896ec79db0b59f9a98fcfd06f6e3a5c7f2946a87 Mon Sep 17 00:00:00 2001 From: George Hu Date: Thu, 19 Dec 2024 15:38:12 -0800 Subject: [PATCH] [lldb] Fix address to read segment data --- lldb/source/Plugi

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

labath wrote: > Updated the commit to address @labath's comment. Can you explain how you did that? The new implementation does something completely different (and wrong on several levels) from the one I pointed you to. [Here](https://android.googlesource.com/platform/bionic/+/android-4.2_r1/l

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

GeorgeHuyubo wrote: Updated the commit to address @labath's comment. https://github.com/llvm/llvm-project/pull/120655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/120655 >From 72d214dc2e6d9754ae5525a9161924f140d92e3c Mon Sep 17 00:00:00 2001 From: George Hu Date: Thu, 19 Dec 2024 15:38:12 -0800 Subject: [PATCH] [lldb] Fix address to read segment data --- lldb/source/Plugi

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/120655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

https://github.com/labath commented: I'm pretty sure this is not correct. `p_offset` is an offset in the file. It tells you nothing about how the file is mapped into memory. What you're *probably* running into is an executable whose base address (`p_vaddr` of the first `PT_LOAD` segment) is no

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes Previous commit https://github.com/llvm/llvm-project/commit/bcf654c7f5fb84dd7cff5fe112d96658853cd8f5 introduced a bug which makes lldb unable to parse gnu build id for the main executable from a core file. This

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/120655 Previous commit https://github.com/llvm/llvm-project/commit/bcf654c7f5fb84dd7cff5fe112d96658853cd8f5 introduced a bug which makes lldb unable to parse gnu build id for the main executable from a core file.