[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: > This string comes from the debug/lldb-server, and MacOS has a... complicated > compatibility story for the debugserver. It's not to the same level, but doesn't everyone else have this issue, potentially? Though the consequence is just that if my lldb-server is old and

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread Pavel Labath via lldb-commits
labath wrote: > I see you changed the MTE core file case, there is a live process test case > too, a search for `fault address:` should find it and any others. Done, and I've changed a couple of extra strings as well https://github.com/llvm/llvm-project/pull/123217

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread Pavel Labath via lldb-commits
labath wrote: > We could make MacOS adopt the Linux format, right? Not that that changes much > but just wondering if there's any reason you chose that direction. The reason I chose this direction is because I still think of MacOS as the "reference platform" for lldb, but now that I've thought

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: We could make MacOS adopt the Linux format, right? Not that that changes much but just wondering if there's any reason you chose that direction. I see you changed the MTE core file case, there is a live process test case too, a search for `fault address:` should find it an

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -10,7 +10,7 @@ class TestDiagnoseDereferenceFunctionReturn(TestBase): -@skipUnlessDarwin +@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples())) labath wrote: Yep https://github.com/llvm/llvm-project/pull/123217 _

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread David Spickett via lldb-commits
@@ -10,7 +10,7 @@ class TestDiagnoseDereferenceFunctionReturn(TestBase): -@skipUnlessDarwin +@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples())) DavidSpickett wrote: This test previously could not run anywhere but Darwin but n

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-16 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/123217 .. by changing the signal stop reason format :facepalm: The reason this did not work is because the code in `StopInfo::GetCrashingDereference` was looking for the string "address=" to extract the address of the

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes .. by changing the signal stop reason format :facepalm: The reason this did not work is because the code in `StopInfo::GetCrashingDereference` was looking for the string "address=" to extract the address of t