[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns A parsed XcodeSDK object if s

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Greg Clayton via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns A parsed XcodeSDK object if s

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1d95825d4d168a17a4f27401dec3f2977a59a70e 4facb5fc17280c27af99b014e621f7a573afb929 --e

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread via lldb-commits
https://github.com/Alexizx0078 approved this pull request. https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119022 >From 60ab35f50652e761d465cc1410b8d3352fa86b3f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 6 Dec 2024 12:09:27 -0800 Subject: [PATCH 1/2] [lldb] Add a per-CU API to read the SDK. This is neede

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Jonas Devlieghere via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns If successful, returns a pars

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns If successful, returns a pars

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread via lldb-commits
https://github.com/Alexizx0078 approved this pull request. https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Jonas Devlieghere via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns If successful, returns a pars

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Jonas Devlieghere via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns If successful, returns a pars

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119022 >From 60ab35f50652e761d465cc1410b8d3352fa86b3f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 6 Dec 2024 12:09:27 -0800 Subject: [PATCH] [lldb] Add a per-CU API to read the SDK. This is needed by

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Med Ismail Bennani via lldb-commits
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Med Ismail Bennani via lldb-commits
@@ -473,6 +473,38 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK paths the CUs was compiled against. In the + /// presence of different SDKs, we try to pick the most appropriate + /// one

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/119022.diff 4 Files Affected: - (modified) lldb/include/lldb/Target/Platform.h (+32) - (modified) lldb/source/Plugins/Platform/MacOSX/Platfo

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread via lldb-commits
https://github.com/Alexizx0078 approved this pull request. https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/119022 None >From aadb454d36e4c5058fffcc946a9ce97d7e25bf39 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 6 Dec 2024 12:09:27 -0800 Subject: [PATCH] [lldb] Add a per-CU API to read the SDK --- lldb/in