@@ -18,6 +18,26 @@ def tearDown(self):
if self.background_pid:
os.kill(self.background_pid, signal.SIGKILL)
+def test_getname(self):
+"""Test the SBModule::GetName() method"""
+self.build()
+target, _, _, _ = lldbutil.run_to_sour
@@ -18,6 +18,26 @@ def tearDown(self):
if self.background_pid:
os.kill(self.background_pid, signal.SIGKILL)
+def test_getname(self):
+"""Test the SBModule::GetName() method"""
+self.build()
+target, _, _, _ = lldbutil.run_to_sour
@@ -18,6 +18,26 @@ def tearDown(self):
if self.background_pid:
os.kill(self.background_pid, signal.SIGKILL)
+def test_getname(self):
+"""Test the SBModule::GetName() method"""
+self.build()
+target, _, _, _ = lldbutil.run_to_sour
@@ -18,6 +18,26 @@ def tearDown(self):
if self.background_pid:
os.kill(self.background_pid, signal.SIGKILL)
+def test_getname(self):
+"""Test the SBModule::GetName() method"""
+self.build()
+target, _, _, _ = lldbutil.run_to_sour
labath wrote:
I don't think that `m_object_name` is what you're looking for. It's supposed to
be used for disambiguation when a single physical file contains multiple
logical object files, such as with BSD archives. It being empty for "normal"
files is kind of expected:
```
ConstString m_obj
https://github.com/barsolo2000 updated
https://github.com/llvm/llvm-project/pull/150331
>From b79edf938d49d03498ec3a9228344a684d0cbf6e Mon Sep 17 00:00:00 2001
From: Bar Soloveychik
Date: Wed, 23 Jul 2025 15:17:29 -0700
Subject: [PATCH 1/3] [LLDB] added getName method in SBModule
---
lldb/inc
@@ -671,3 +671,15 @@ void SBModule::GarbageCollectAllocatedModules() {
const bool mandatory = false;
ModuleList::RemoveOrphanSharedModules(mandatory);
}
+
+const char *SBModule::GetName() const {
+ LLDB_INSTRUMENT_VA(this);
JDevlieghere wrote:
There shoul
@@ -671,3 +671,15 @@ void SBModule::GarbageCollectAllocatedModules() {
const bool mandatory = false;
ModuleList::RemoveOrphanSharedModules(mandatory);
}
+
+const char *SBModule::GetName() const {
+ LLDB_INSTRUMENT_VA(this);
+ if (!m_opaque_sp) {
+return nullptr;
+ }
@@ -671,3 +671,15 @@ void SBModule::GarbageCollectAllocatedModules() {
const bool mandatory = false;
ModuleList::RemoveOrphanSharedModules(mandatory);
}
+
+const char *SBModule::GetName() const {
+ LLDB_INSTRUMENT_VA(this);
+ if (!m_opaque_sp) {
+return nullptr;
+ }
@@ -671,3 +671,15 @@ void SBModule::GarbageCollectAllocatedModules() {
const bool mandatory = false;
ModuleList::RemoveOrphanSharedModules(mandatory);
}
+
+const char *SBModule::GetName() const {
+ LLDB_INSTRUMENT_VA(this);
+ if (!m_opaque_sp) {
+return nullptr;
+ }
@@ -671,3 +671,15 @@ void SBModule::GarbageCollectAllocatedModules() {
const bool mandatory = false;
ModuleList::RemoveOrphanSharedModules(mandatory);
}
+
+const char *SBModule::GetName() const {
+ LLDB_INSTRUMENT_VA(this);
+ if (!m_opaque_sp) {
+return nullptr;
+ }
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/150331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
TL;DR:
```suggestion
const char *SBModule::GetName() const {
LLDB_INSTRUMENT_VA(this);
if (!m_opaque_sp)
return nullptr;
return m_opaque_sp->GetObjectName().AsCString();
}
```
This also needs a test.
https://g
https://github.com/barsolo2000 updated
https://github.com/llvm/llvm-project/pull/150331
>From b79edf938d49d03498ec3a9228344a684d0cbf6e Mon Sep 17 00:00:00 2001
From: Bar Soloveychik
Date: Wed, 23 Jul 2025 15:17:29 -0700
Subject: [PATCH 1/2] [LLDB] added getName method in SBModule
---
lldb/inc
14 matches
Mail list logo
