https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,6 +144,9 @@ class Progress {
/// Data needed by the debugger to broadcast a progress event.
const ProgressData m_progress_data;
+ /// The origin of this progress event.
+ const Origin m_origin;
Jlalond wrote:
Good catch! Fixed.
https://github.c
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/7] Add external progress bit category
---
lldb/include/lldb/C
https://github.com/JDevlieghere approved this pull request.
LGTM with the redundant field removed.
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,6 +144,9 @@ class Progress {
/// Data needed by the debugger to broadcast a progress event.
const ProgressData m_progress_data;
+ /// The origin of this progress event.
+ const Origin m_origin;
JDevlieghere wrote:
This seems redundant if we stor
Jlalond wrote:
Hey @JDevlieghere, I was out for the holidays, but did you want to take a
second look at this? Or can I land it to rebase the SBProgress changes on top
of?
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/6] Add external progress bit category
---
lldb/include/lldb/C
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/5] Add external progress bit category
---
lldb/include/lldb/C
@@ -106,9 +107,15 @@ void Progress::ReportProgress() {
if (completed < m_prev_completed)
return; // An overflow in the m_completed counter. Just ignore these
events.
+ // Change the category bit if we're an internal or external progress.
+ uint32_t progress_category_b
@@ -195,10 +195,10 @@ enum Format {
///< character arrays that can contain non printable
///< characters
eFormatAddressInfo,///< Describe what an address points to (func + offset
- ///< with file/line,
@@ -1357,6 +1357,7 @@ enum DebuggerBroadcastBit {
eBroadcastBitError = (1 << 2),
eBroadcastSymbolChange = (1 << 3),
eBroadcastBitProgressCategory = (1 << 4),
+ eBroadcastBitExternalProgressCategory = (1 << 5),
JDevlieghere wrote:
You'll also need to add
@@ -149,6 +156,9 @@ class Progress {
/// The "completed" value of the last reported event.
std::optional m_prev_completed;
+
+ /// The origin of this progress event.
+ ProgressOrigin m_origin;
JDevlieghere wrote:
Pavel const'ified the things that cannot
@@ -106,9 +107,15 @@ void Progress::ReportProgress() {
if (completed < m_prev_completed)
return; // An overflow in the m_completed counter. Just ignore these
events.
+ // Change the category bit if we're an internal or external progress.
+ uint32_t progress_category_b
@@ -21,6 +21,12 @@
namespace lldb_private {
+/// Enum to indicate the origin of a progress event, internal or external.
+enum class ProgressOrigin : uint8_t {
+ eLLDBInternal = 0,
+ eExternal = 1,
JDevlieghere wrote:
Let's go with `eInternal` and `eExterna
Jlalond wrote:
@JDevlieghere I'm hoping I did this right, additionally any preference on where
the enum should live? I debated on enumerations and just make a generic
'eventorigin' enumeration that we could reuse for events in the future. But I
figured that was reaching.
https://github.com/ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
As feedback on #119052, it was recommended I add a new bit to delineate
internal and external progress events. This patch adds this new category, and
sets up Progress.h to support external events via SBProgr
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/120171
As feedback on #119052, it was recommended I add a new bit to delineate
internal and external progress events. This patch adds this new category, and
sets up Progress.h to support external events via SBProgress
18 matches
Mail list logo
