DavidSpickett wrote:
First, thanks for fixing this. It has been on Linaro's backlog for a while but
as usual resources are scarce.
> Currently, watchpoints don't work on Windows (this can be reproduced with the
> existing tests).
For background here, the Windows LLDB bot is run by Linaro and
github-actions[bot] wrote:
@AlexK0 Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/95446
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/95446
>From 0053a9cfdd4637be0d52901b5d871ed1c43e06a1 Mon Sep 17 00:00:00 2001
From: Aleksandr Korepanov
Date: Thu, 13 Jun 2024 15:56:08 +0200
Subject: [PATCH 1/2] [LLDB][Windows] Fix watchpoints for Windows
The p
AlexK0 wrote:
> Do you have permissions to merge the PR?
I don't have the necessary permissions. Could you please merge the PR when it
becomes possible?
https://github.com/llvm/llvm-project/pull/95446
___
lldb-commits mailing list
lldb-commits@lists.
@@ -406,7 +406,7 @@ void ProcessWindows::RefreshStateAfterStop() {
m_session_data->m_debugger->GetProcess().GetProcessId(), pc,
id);
stop_info = StopInfo::CreateStopReasonWithWatchpointID(
- *stop_thread, id, m_watchpoints[id].address);
+
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Aleksandr Korepanov (AlexK0)
Changes
Hello!
Currently, watchpoints don't work on Windows (this can be reproduced with the
existing tests). This patch fixes the related issues so that the tests and
watchpoints start working.
Here is the l
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/jasonmolenda approved this pull request.
Thanks for the fixes, these are correct and they look like they're caused by me
when I was doing my work on watchpoints earlier this year. Do you have
permissions to merge the PR?
https://github.com/llvm/llvm-project/pull/95446
_
https://github.com/AlexK0 updated
https://github.com/llvm/llvm-project/pull/95446
>From 0053a9cfdd4637be0d52901b5d871ed1c43e06a1 Mon Sep 17 00:00:00 2001
From: Aleksandr Korepanov
Date: Thu, 13 Jun 2024 15:56:08 +0200
Subject: [PATCH 1/2] [LLDB][Windows] Fix watchpoints for Windows
The patch f
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ffab938f50fa999f2218976f7de78cf8e4f70d4e
0053a9cfdd4637be0d52901b5d871ed1c43e06a1 --
https://github.com/AlexK0 created
https://github.com/llvm/llvm-project/pull/95446
Hello!
Currently, watchpoints don't work on Windows (this can be reproduced with the
existing tests). This patch fixes the related issues so that the tests and
watchpoints start working.
Here is the list of tes
12 matches
Mail list logo
