jingham added a comment.
I think it's fine to fall back to the "currently selected target" if the
command interpreter doesn't have a current execution context, that should not
be your first choice.
For instance, if you are running this command in a Python breakpoint callback,
then the current
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG754ab803b8dc: [lldb] Use current execution context in
SBDebugger (authored by werat, committed by teemperor).
Repository:
rG LLVM Github Monorepo
werat added a comment.
Thanks for the review! Can you submit it for me, since I don't have commit
access?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95761/new/
https://reviews.llvm.org/D95761
___
lld
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95761/new/
https://reviews.llvm.org/D95761
__
werat created this revision.
werat requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Use `GetSelectedExecutionContext()` instead of
`GetCommandInterpreter().GetExecutionContext()` in
`SBDebugger::GetInternalVariableValue/SBDebugger::SetInte
