[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows

2021-02-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. (I'm very sorry for the delay, that slipped out of my review queue.) Wouldn't changing this logic to an explicit `get_target_property` call break the multi-config projects (whe

[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows

2021-01-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM but I'd like @teemperor to have a look too as he authored the original change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95

[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows

2021-01-21 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd created this revision. compnerd added a reviewer: JDevlieghere. compnerd added a project: LLDB. Herald added a subscriber: mgorny. compnerd requested review of this revision. Herald added a subscriber: lldb-commits. The previous code path only happened to work incidentally. The `file(MAK