This revision was automatically updated to reflect the committed changes.
Closed by commit rGbae9aedb341c: [LLDB] Fix handling of bit-fields in a union
(authored by shafik).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91118/new/
https://reviews.llvm.org/D91118
___
lldb-commits mailing list
shafik updated this revision to Diff 304354.
shafik added a comment.
Add a check to make sure the bit offset is zero for fields in a union.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91118/new/
https://reviews.llvm.org/D91118
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPar
teemperor added a comment.
Should we maybe check that the offset is 0 instead of skipping the sanity
check? Otherwise this LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91118/new/
https://reviews.llvm.org/D91118
___
lldb-commits mailin
shafik created this revision.
shafik added reviewers: teemperor, aprantl.
shafik requested review of this revision.
When laying out bit-fields we don't properly take into account when they are in
a union, they will all have a zero offset.
https://reviews.llvm.org/D91118
Files:
lldb/source/Pl
