[Lldb-commits] [PATCH] D90895: [TargetList] Delete the destructor

2020-11-05 Thread Vedant Kumar via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65d15fefe339: [TargetList] Delete the destructor (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D90895: [TargetList] Delete the destructor

2020-11-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90895/new/ https://reviews.llvm.org/D90895 _

[Lldb-commits] [PATCH] D90895: [TargetList] Delete the destructor

2020-11-05 Thread Vedant Kumar via Phabricator via lldb-commits
vsk created this revision. vsk added reviewers: teemperor, JDevlieghere, jingham. Herald added a project: LLDB. vsk requested review of this revision. AFAICT, ~TargetList simply implements the default destructor, plus some locking. The history is murky, so I'm not sure why we do this locking. Per