[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90857/new/ https://reviews.llvm.org/D90857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-19 Thread Richard Howell via Phabricator via lldb-commits
rmaz added a comment. > I'd still like to hear an explanation on how is this patch relevant (in this > repository). Apologies, missed the last notification. > Judging by the error message, this dependency is not correct even in the > swift fork. lldbSymbol does not have a direct dependency on

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Ping! I'd still like to hear an explanation on how is this patch relevant (in this repository). Per our code review policy , the responsibility for a patch does not end the moment the patch is committed : Post-commit review is e

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D90857#2379761 , @teemperor wrote: > Just to clarify: This only a dependency in the downstream Swift branch? Judging by the error message, this dependency is not correct even in the swift fork. lldbSymbol does not have a direct

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-06 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Just to clarify: This only a dependency in the downstream Swift branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90857/new/ https://reviews.llvm.org/D90857 ___ lldb-commit

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-06 Thread Nathan Lanza via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG137ff7331705: [lldb] add a missing dependency on intrinsics_gen (authored by rmaz, committed by lanza). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: ht