[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826997c46280: [lldb] Fix a regression introduced by D75730 (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D89925?vs

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. If needed, we can add some `#ifdef`s to produce suitable instructions on other architectures too. Comment at: lldb/source/Core/Disassembler.cpp:544

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

JDevlieghere added a comment. In D89925#2346290 , @jasonmolenda wrote: > So in this patch you're setting the limit to be the size of the range (for > someone who did 'disass -s 0x100 -e 0x200' they would be requesting 100 > instructions) but the disasse

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

jasonmolenda added a comment. (*cough* "requesting 256 instructions", wrote too quickly, or rather I am speaking in gdb RSP and don't always prefix my base16 numbers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89925/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

jasonmolenda added a comment. So in this patch you're setting the limit to be the size of the range (for someone who did 'disass -s 0x100 -e 0x200' they would be requesting 100 instructions) but the disassembly returned would be limited by the byte range requested, so this works OK. The asm(no

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a subscriber: pengfei. Herald added a project: LLDB. JDevlieghere requested review of this revision. In a new Range class was introduced to simplify and the Disassembler API and reduce duplication. It