[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. In D89812#2354862 , @stella.stamenova wrote: > load-pdb is still failing on the Windows bot. Can you please commit a fix > soon or revert the change? It's slash vs back slash thing. Put a fix at https://reviews.llvm.org/rG779d

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. In D89812#2354862 , @stella.stamenova wrote: > load-pdb is still failing on the Windows bot. Can you please commit a fix > soon or revert the change? Okay, I'm looking at it now Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

stella.stamenova added a comment. load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 __

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. In D89812#2354320 , @jankratochvil wrote: > It has regressed buildbots: > > SymbolFile/NativePDB/load-pdb.cpp > lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006 > lldb-x86_64-debian: http://lab.llvm.or

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

jankratochvil added a comment. It has regressed buildbots: SymbolFile/NativePDB/load-pdb.cpp lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006 lldb-x86_64-debian: http://lab.llvm.org:8011/#/builders/68/builds/782 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG242e1e991044: [lldb][PDB] Add ObjectFile PDB plugin (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 300720. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/source/Plugins/ObjectFile/PDB/CMakeLists.txt:6 +lldbCore +lldbHost +lldbSymbol I don't see this using any Host functionalit

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

amccarth added a comment. This looks pretty good, both the patch and Pavel's insights. I don't see much to comment on that Pavel didn't already catch. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:168 + + ArchSpec &spec = module_spec.GetArchitecture(); +

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(module_spec); +break; + case PDB_Machin

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 300388. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(module_spec); +break; + case PDB_Machine:

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(module_spec); +break; + case PDB_Machin

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 300133. zequanwu marked 4 inline comments as done. zequanwu added a comment. Herald added a subscriber: arphaman. Address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(module_spec); +break; + case PDB_Machine:

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(m

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 299826. zequanwu marked 4 inline comments as done. zequanwu added a comment. - address comments. - add tests. - move `loadPDBFile` from `SymbolFileNativePDB.cpp` to `ObjectFilePDB.cpp` and use it to create unique_ptr of `PDBFile` so that we can move it aroun

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath added a comment. I think this is a good start. See inline comments for details. In addition to the test for the "target symbols add" flow it would be good to have a separate test for the ObjectFilePDB functionality. You can look at existing tests in `test/Shell/ObjectFile` for inspiratio

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 299527. zequanwu added a comment. elaborate CHECK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files: lldb/source/Plugins/ObjectFile/CMakeLists.txt lldb/source/

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 299525. zequanwu added a comment. - Add `GetArchitecture` method, similar to ObjectFilePECOFF - Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files:

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. How can I start lldb at specified path so that `target symbols add bar.pdb` could find the pdb path? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 __

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu created this revision. zequanwu added reviewers: labath, amccarth. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. zequanwu requested review of this revision. Herald added a subscriber: JDevlieghere. To allow loading PDB file with `target symbols add` command