[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat abandoned this revision. werat added a comment. Herald added a subscriber: pengfei. Refactored in D88249 to avoid this problem altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88247/new/ https://rev

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat added a comment. Thanks for reviewing and writing a follow-up change! Changing the ctor to accept a const reference is indeed a cleaner solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88247/new/ https://reviews.llvm.org/D88247 _

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I meant to accept this, we can land this and deal with my suggestion as a follow up. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

JDevlieghere added a comment. Good catch, thank you! I wanted to suggest making the `SBAddress` constructor take the `Address` by const-reference but wanted to see how much work that'd be which resulted in D88249 . Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat created this revision. werat added a reviewer: labath. werat added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: JDevlieghere. werat requested review of this revision. SBAddress constructor accepts a pointer to `lldb_private::Address`, but th