This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcdcb9ab10e53: Revert "Use find_library for
ncurses" (authored by haampie, committed by gkistanova).
Changed prior to commit:
https://reviews.llvm.
gkistanova added a comment.
Hi Petr,
I don't have a strong opinion on the exact way of fixing the problem. But we
should do this as soon as possible, as keeping the bots red for that long is
not Ok.
Please send me your patch and I will check it on lld-perf-testsuite bot. If you
do not have th
phosek added a comment.
I have suggested an alternative in https://reviews.llvm.org/D85820#2237357 to
try and fix this forward and I was waiting for @haampie's response before
landing this. I can implement that today if you're OK fixing this forward? I
think it'd be easier to do that than rever
haampie added a comment.
@phosek it would be great to get that patch in, but the truth is it is
difficult testing across multiple platforms for me; I can only test on Linux
and macOS, not Windows (GNU). Since that patch would touch predefined,
platform-dependent cmake variables, I would want to
gkistanova added a comment.
Fair enough. Reverted.
https://github.com/llvm/llvm-project/commit/cdcb9ab10e53ff08293915af3cd897c42112bcc5
Thanks, everyone!
Petr, please feel free to send me a patch you want me to check for you. Make
sure I could apply it on top of the trunk.
Repository:
rG LL
gkistanova added a comment.
Hi Mateusz,
Yes, this looks like a separate patch on top of this revert.
By the way, this hasn't been merged yet. Are we waiting for anything? Harmen,
do you need a help committing this patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
mati865 added a comment.
FYI this doesn't fully fix MinGW issue:
$ cat tools/llvm-config/BuildVariables.inc | grep LLVM_SYSTEM_LIBS
#define LLVM_SYSTEM_LIBS "-lpsapi -lshell32 -lole32 -luuid -ladvapi32 -lz.dll"
It's because libraries are found by their import library which is `libz.dll.a`
i
gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.
I have checked this patch with
http://lab.llvm.org:8011/builders/lld-perf-testsuite bot. It makes it green.
Thanks for reverting, Harmen!
Repository:
rG LLVM Github Monorepo
CHANG
haampie created this revision.
haampie added reviewers: JDevlieghere, phosek, gkistanova.
Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, hiraditya,
mgorny.
Herald added projects: Sanitizers, LLDB, LLVM.
haampie requested review of this revision.
The introduction of find_library
